output: optimize branch condition in metadata generation#5289
Merged
Conversation
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Contributor
|
How does it affect to Before: [] => time,tag => time => tag Because priority was changed in this case. |
Contributor
Author
|
Yes, as you pointed out, the evaluation for the Since the main goal of this PR is to optimize the most common cases (using |
kenhys
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #
What this PR does / why we need it:
This PR optimizes the branch conditions inside the
metadatageneration inFluent::Plugin::Output.In most production use cases, either
timeortag(or both) are used as chunk keys.When running
rake benchmark:run:in_tailwith a 10 GB file:rake benchmark:run:in_tailDocs Changes:
N/A
Release Note: