Feature/ranking - #29
Open
mrskiro wants to merge 58 commits into
Open
Conversation
added 14 commits
May 29, 2020 18:08
Contributor
Author
|
soundも流せるようになりました。 |
Contributor
|
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
わかりました！やってみます！ |
Contributor
Author
|
すべて修正できました！確認お願いします！ デプロイもしています |
so99ynoodles
suggested changes
Jun 1, 2020
so99ynoodles
left a comment
so99ynoodles
left a comment
Contributor
There was a problem hiding this comment.
気になって点としては、rankingに行った場合の挙動かな。
- 音楽が途切れてしまう
- 音楽を無効にしてrankingに行って戻った時にまた流れる
- そのまま戻ったらゲームが再開されるけど、rankingの中でlevelを変えてから戻ると変えたlevelでやり直しになるから、挙動が統一されてないと感じちゃう
あと、前にslackにも投げたけど、クリアしてないのにクリアした扱いにされたケースがあるので、クリアのロジックにバグがある可能性があるね、、
added 30 commits
June 2, 2020 18:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
【概要】
ランキングページの追加及びデータの取得、追加、絞り込み、ソート
【変更内容】
firestoreと連携しました。
公開することを意識して、チュートリアルと画面上部のヘッダーを追加しました。
【詳細】
ランキングページ→react-tableの使用
https://minesweeeeeper.web.app/
なんとか動いていると思います。
よろしくおねがいします！