feat: Support more image formats on Android (#634)

* Support more image formats on Android * Use meta data * Changelog + Version increase + Docs
flutter-ml · May 30, 2024 · e8338de · e8338de
1 parent 7d64419
commit e8338de
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 3 deletions.
diff --git a/packages/google_mlkit_commons/CHANGELOG.md b/packages/google_mlkit_commons/CHANGELOG.md
@@ -1,3 +1,8 @@
+## 0.7.2
+
+* Widened image format support for Android
+* Improve documentation for image formats
+
 ## 0.7.1
 
 * Update README.

diff --git a/...gle_mlkit_commons/android/src/main/java/com/google_mlkit_commons/InputImageConverter.java b/...gle_mlkit_commons/android/src/main/java/com/google_mlkit_commons/InputImageConverter.java
@@ -37,7 +37,7 @@ public static InputImage getInputImageFromData(Map<String, Object> imageData,
                     (int) (double) metaData.get("width"),
                     (int) (double) metaData.get("height"),
                     (int) metaData.get("rotation"),
-                    InputImage.IMAGE_FORMAT_NV21);
+                    (int) metaData.get("image_format"));
             return inputImage;
         } else {
             result.error("InputImageConverterError", "Invalid Input Image", null);

diff --git a/packages/google_mlkit_commons/lib/src/input_image.dart b/packages/google_mlkit_commons/lib/src/input_image.dart
@@ -62,7 +62,15 @@ class InputImageMetadata {
 
   /// Format of the input image.
   ///
-  /// Not used on Android.
+  /// Android supports
+  /// - [InputImageFormat.nv21]
+  /// - [InputImageFormat.yuv_420_888]
+  /// - [InputImageFormat.yv12]
+  /// as described in [here](https://developers.google.com/android/reference/com/google/mlkit/vision/common/InputImage.ImageFormat).
+  ///
+  /// iOS supports
+  /// - [InputImageFormat.yuv420]
+  /// - [InputImageFormat.bgra8888]
   final InputImageFormat format;
 
   /// The row stride for color plane, in bytes.
@@ -122,10 +130,19 @@ extension InputImageRotationValue on InputImageRotation {
 
 /// To indicate the format of image while creating input image from bytes
 enum InputImageFormat {
+  /// Android only: https://developers.google.com/android/reference/com/google/mlkit/vision/common/InputImage#IMAGE_FORMAT_NV21
   nv21,
+
+  /// Android only: https://developers.google.com/android/reference/com/google/mlkit/vision/common/InputImage#public-static-final-int-image_format_yv12
   yv12,
+
+  /// Android only: https://developers.google.com/android/reference/com/google/mlkit/vision/common/InputImage#public-static-final-int-image_format_yuv_420_888
   yuv_420_888,
+
+  /// iOS only: https://developer.apple.com/documentation/corevideo/kCVPixelFormatType_420YpCbCr8BiPlanarFullRange
   yuv420,
+
+  /// iOS only: https://developer.apple.com/documentation/corevideo/kcvpixelformattype_32bgra
   bgra8888,
 }
 

diff --git a/packages/google_mlkit_commons/pubspec.yaml b/packages/google_mlkit_commons/pubspec.yaml
@@ -1,6 +1,6 @@
 name: google_mlkit_commons
 description: A Flutter plugin with commons files to implement google's standalone ml kit made for mobile platform.
-version: 0.7.1
+version: 0.7.2
 homepage: https://github.com/flutter-ml/google_ml_kit_flutter
 
 environment: