-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add rotation to iOS (the sequel) #548
Merged
Merged
Changes from 13 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
b2439a5
add rotation to ios
juanmartin8a 1cd678c
Merge branch 'master' into add_rotation
juanmartin8a bfb8bc8
fixed landscape rotation
juanmartin8a 70887ac
Merge remote-tracking branch 'origin/add_rotation' into add_rotation
juanmartin8a 7742705
moved rotation to mlkit_commons visionImageFromData
juanmartin8a 4ff9aa2
Merge branch 'master' into add_rotation
juanmartin8a 3a12c56
Merge branch 'master' into add_rotation
fbernaly 81252f5
Merge branch 'flutter-ml:develop' into add_rotation
juanmartin8a 60a486a
add camera_lens_direction in the InputImage metadata, for usage in iO…
juanmartin8a d91e106
forgot to call the imageOrientationFromRotation function with the new…
juanmartin8a a7e50dc
error fixes
juanmartin8a a5da490
misspelled class extension for InputImageCameraLensDirection
juanmartin8a 781fb31
better comments
juanmartin8a fa36ab0
removed image rotation when the image is a file because it already do…
juanmartin8a fc31bf0
Merge branch 'develop' into add_rotation
juanmartin8a c663c72
Merge branch 'develop' into add_rotation
fbernaly File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not needed. When the image is a file, camera lens is not used.
Also, check what it is happening inside
filePathToVisionImage
: https://github.com/flutter-ml/google_ml_kit_flutter/blob/develop/packages/google_mlkit_commons/ios/Classes/MLKVisionImage%2BFlutterPlugin.m#L20-L25There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Orientation is already set in that method for files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I didn't noticed that. I already made a new commit with those changes.