Skip to content

Remove deprecated analysis_getReachableSources method - #536

Open
ranbeuer wants to merge 3 commits into
flutter:mainfrom
ranbeuer:cidfabila/analysis_getReachableSources
Open

Remove deprecated analysis_getReachableSources method#536
ranbeuer wants to merge 3 commits into
flutter:mainfrom
ranbeuer:cidfabila/analysis_getReachableSources

Conversation

@ranbeuer

Copy link
Copy Markdown

Summary


  • Remove the deprecated analysis_getReachableSources(String file, GetReachableSourcesConsumer consumer);
    declaration from AnalysisServer.
  • Remove its corresponding no-op override from RemoteAnalysisServerImpl.
  • Eliminate the related deprecated API warning from the IntelliJ Plugin Verifier reports.

Verification

The following commands completed successfully:

  • ./gradlew buildPlugin
  • ./gradlew :test --tests "com.jetbrains.lang.dart.*"
  • ./gradlew :test --tests "com.jetbrains.dart.*" -PverboseTests
  • ./gradlew verifyPlugin
  • ./gradlew verifyPluginProjectConfiguration
  • ./gradlew verifyPluginSignature
  • ./gradlew verifyPluginStructure

The analysis_getReachableSources warning is no longer present in the Plugin Verifier reports for IU-253, IU-261, or IU-262.

Screenshots are not applicable because this change does not affect the UI.

Review the contribution guidelines below:

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
  • I've included the required information in the description above.
  • I've updated CHANGELOG.md if appropriate (i.e. user-facing change)
Contribution guidelines:
  • See the Flutter organization contributor guide for general expectations for PRs.
  • Larger or significant changes should be discussed in an issue before creating a PR.
  • Dart contributions to our repos should follow the Dart style guide and use
    dart format.
  • Java and Kotlin contributions should strive to follow Java and Kotlin best
    practices (discussion).

@google-cla

google-cla Bot commented Jul 24, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the deprecated 'analysis_getReachableSources' method from the 'AnalysisServer' interface and its implementation in 'RemoteAnalysisServerImpl'. The reviewer recommends completing the cleanup by removing the now-unused 'GetReachableSourcesConsumer' import and deleting the obsolete 'GetReachableSourcesConsumer.java' file.

I am having trouble creating individual review comments. Click here to see my feedback.

third_party/thirdPartySrc/analysisServer/com/google/dart/server/internal/remote/RemoteAnalysisServerImpl.java (334-337)

medium

[CONCERN] Removing the analysis_getReachableSources method makes the GetReachableSourcesConsumer interface and its import on line 41 of this file obsolete. Please remove the unused import and delete the GetReachableSourcesConsumer.java file to complete the cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant