Remove deprecated analysis_getReachableSources method - #536
Conversation
Add a skill for migrating to LSP (flutter#535)
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request removes the deprecated 'analysis_getReachableSources' method from the 'AnalysisServer' interface and its implementation in 'RemoteAnalysisServerImpl'. The reviewer recommends completing the cleanup by removing the now-unused 'GetReachableSourcesConsumer' import and deleting the obsolete 'GetReachableSourcesConsumer.java' file.
I am having trouble creating individual review comments. Click here to see my feedback.
third_party/thirdPartySrc/analysisServer/com/google/dart/server/internal/remote/RemoteAnalysisServerImpl.java (334-337)
[CONCERN] Removing the analysis_getReachableSources method makes the GetReachableSourcesConsumer interface and its import on line 41 of this file obsolete. Please remove the unused import and delete the GetReachableSourcesConsumer.java file to complete the cleanup.
Summary
declaration from AnalysisServer.
Verification
The following commands completed successfully:
./gradlew buildPlugin./gradlew :test --tests "com.jetbrains.lang.dart.*"./gradlew :test --tests "com.jetbrains.dart.*" -PverboseTests./gradlew verifyPlugin./gradlew verifyPluginProjectConfiguration./gradlew verifyPluginSignature./gradlew verifyPluginStructureThe analysis_getReachableSources warning is no longer present in the Plugin Verifier reports for IU-253, IU-261, or IU-262.
Screenshots are not applicable because this change does not affect the UI.
Review the contribution guidelines below:
CHANGELOG.mdif appropriate (i.e. user-facing change)Contribution guidelines:
dart format.practices (discussion).