-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚙️ Flip org.jetbrains.android
to optional
#7949
Open
AlexV525
wants to merge
9
commits into
flutter:master
Choose a base branch
from
AlexV525:feat/optional-android-dep
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+12
−3
Open
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
c5760a1
⚙️ Flip `org.jetbrains.android` to optional
AlexV525 aeea61f
Update plugin_template.xml
AlexV525 f0bb84e
🔧 Apply config file
AlexV525 66e40e4
📝 Align docs
AlexV525 a23d5fd
🛂 Update AUTHORS
AlexV525 57e733c
Merge branch 'refs/heads/master' into feat/optional-android-dep
AlexV525 5dcab7c
📝 Fix CONTRIBUTING
AlexV525 9291a37
Revert "📝 Fix CONTRIBUTING"
AlexV525 7ff257b
Revert "📝 Align docs"
AlexV525 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,7 +13,7 @@ ChangJoo Park <[email protected]> | |
Amol Grover <[email protected]> | ||
Jeremy Judeaux <[email protected]> | ||
Letticia Nicoli <[email protected]> | ||
Alex Li <google@alexv525.com> | ||
Alex Li <alexv.525.li@gmail.com> | ||
Marcus Tomlinson <[email protected]> | ||
Juyeong Lee <[email protected]> | ||
Hrishikesh Kadam <[email protected]> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
<!-- | ||
~ Copyright 2025 The Chromium Authors. All rights reserved. | ||
~ Use of this source code is governed by a BSD-style license that can be | ||
~ found in the LICENSE file. | ||
--> | ||
|
||
<!-- Defines Android-supported IDE-specific contributions and implementations. --> | ||
<idea-plugin> | ||
</idea-plugin> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Did you mean to remove "Flutter is a multi-platform"? Right now there's no space between platform and Flutter.
The updates to the README look good other than the above nit. However, I might split out the changes to the README into a separate PR as they seem unrelated to the the changes to make org.jetbrains.android optional and could be merged separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the catch. I was trying to copy the latest description from the Flutter repo but seems not make it clean. I'll split changes to another PR later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done revert