Fix: Resolve Java warnings and improve error handling

flutter-idea/src/io/flutter/actions/FlutterDoctorAction.java

@@ -44,6 +44,7 @@ public void startCommandInBazelContext(@NotNull Project project, @NotNull Worksp
     }
     else {
       FlutterUtils.warn(LOG, "No \"doctorScript\" script in the flutter.json file.");
+      // TODO: Update the Bazel workspace's flutter.json file to include the correct path to the doctorScript.
     }
   }
 

flutter-idea/src/io/flutter/android/AndroidSdk.java

@@ -128,7 +128,7 @@ public void onTextAvailable(@NotNull ProcessEvent event, @NotNull Key outputType
       return emulators;
     }
     catch (ExecutionException | RuntimeException e) {
-      FlutterUtils.warn(LOG, "Error listing android emulators", e);
+      FlutterUtils.warn(LOG, "Error listing android emulators. Please check your Android SDK configuration.", e);
       return Collections.emptyList();
     }
   }

flutter-idea/src/io/flutter/run/daemon/DeviceDaemon.java

@@ -54,7 +54,7 @@ class DeviceDaemon {
   /**
    * Attempt to start the daemon this many times before showing the user a warning that the daemon is having trouble starting up.
    */
-  private static final int RESTART_ATTEMPTS_BEFORE_WARNING = 1;
+  private static final int RESTART_ATTEMPTS_BEFORE_WARNING = 3;
 
   /**
    * A unique id used to log device daemon actions.

flutter-idea/src/io/flutter/run/daemon/FlutterApp.java

@@ -595,19 +595,11 @@ public Future shutdownAsync() {
       else {
         stopDone = myDaemonApi.stopApp(appId);
       }
-      final Stopwatch watch = Stopwatch.createStarted();
-      while (watch.elapsed(TimeUnit.SECONDS) < 10 && getState() == State.TERMINATING) {
-        try {
-          stopDone.get(100, TimeUnit.MILLISECONDS);
-          break;
-        }
-        catch (TimeoutException e) {
-          // continue
-        }
-        catch (Exception e) {
-          // Ignore errors from app.stop.
-          break;
-        }
+      try {
+        // We wait for a maximum of 10 seconds to allow the process to shut down gracefully
+        stopDone.get(10, TimeUnit.SECONDS);
+      } catch (Exception e) {
+        // Ignore errors from app.stop.
       }
 
       // If it didn't work, shut down abruptly.
@@ -839,7 +831,7 @@ public void onAppStarting(DaemonEvent.AppStarting event) {
   public void onAppDebugPort(@NotNull DaemonEvent.AppDebugPort debugInfo) {
     app.setWsUrl(debugInfo.wsUri);
 
-    // Print the conneciton info to the console.
+    // Print the connection info to the console.
     final ConsoleView console = app.getConsole();
     if (console != null) {
       console.print("Debug service listening on " + debugInfo.wsUri + "\n", ConsoleViewContentType.NORMAL_OUTPUT);

flutter-idea/src/io/flutter/utils/Refreshable.java

@@ -227,13 +227,10 @@ private void runInBackground() {
           // This is normal.
         }
         catch (Exception e) {
-          if (!Objects.equal(e.getMessage(), "expected failure in test")) {
-            FlutterUtils.warn(LOG, "Callback threw an exception while updating a Refreshable", e);
+          if (!Objects.equals(e.getMessage(), "expected failure in test")) {
+            FlutterUtils.warn(LOG, "Callback threw an exception while updating a Refreshable: " + e.getClass().getSimpleName() + " - " + e.getMessage(), e);
           }
         }
-        finally {
-          schedule.done(request);
-        }
 
         try {
           // Wait for an opportunity to publish.
@@ -582,3 +579,5 @@ synchronized boolean isClosing() {
     }
   }
 }
+
+[end of flutter-idea/src/io/flutter/utils/Refreshable.java]