Skip to content

Refactor product handling logic in build script #8086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025

Conversation

Lootwig
Copy link
Contributor

@Lootwig Lootwig commented Apr 19, 2025

Adds handling for the "IU" (Idea Ultimate) product variant, currently skipped over and failing builds due to android plugin dependency logic being tied to "IC". This conflicts with the contributing.md:

...

  1. Make sure you're using the latest stable release of IntelliJ,
    or download and install the latest version of IntelliJ (2023.1 or later).

    • IntelliJ Downloads
    • Either the community edition (free) or Ultimate will work. <-- no it won't
  2. Create a gradle.properties file.
    ...

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read the [Flutter Style Guide] recently, and have followed its advice.
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

Accounts for possible "IU" product variant not supported by current community-edition specific implementation
@jwren jwren self-requested a review April 21, 2025 20:18
@jwren jwren merged commit 8ea3b61 into flutter:master Apr 23, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants