-
Notifications
You must be signed in to change notification settings - Fork 325
[Property Editor] Enable Property Editor panel #8108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
elliette
commented
Apr 23, 2025
- If the Flutter version does not support the Property Editor, no panel is shown.
- If the Dart plugin version does not support the Property Editor, the following message is shown:

@@ -47,7 +47,7 @@ public final class FlutterSdkVersion implements Comparable<FlutterSdkVersion> { | |||
private static final FlutterSdkVersion MIN_SUPPORTS_DTD = new FlutterSdkVersion("3.22.0"); | |||
|
|||
@NotNull | |||
private static final FlutterSdkVersion MIN_SUPPORTS_PROPERTY_EDITOR = new FlutterSdkVersion("3.29.0"); | |||
public static final FlutterSdkVersion MIN_SUPPORTS_PROPERTY_EDITOR = new FlutterSdkVersion("3.32.0-0.1.pre"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I will leave it to you if this changes at all with cherry picks.
Lgtm! I thought that the flutter plugin version requires a certain dart plugin version, and so it would be possible to control what dart plugin we have without an extra check (which gets confusing since we also have dart sdk checks elsewhere). I see in testing you have this scenario though - is this also going to occur for normal users? |
Oh that would be great if that is the case! Do you know where we tie the flutter plugin version to the dart plugin version? |
The files involved are But I know this can be tricky to update and make sure all the versions are correct. @jwren has more experience testing different build combinations. |