[PE] make color picker “dark theme” aware #8109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

pq merged 1 commit into flutter:master from pq:pe_colorPickerFix

Apr 23, 2025

Contributor

pq commented Apr 23, 2025 •

edited

Loading

java.awt colors are not dark-theme friendly but JBColors are. As a bonus we can use the Gray constant.

I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

See our [contributor guide](https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md for general expectations for PRs.
Larger or significant changes should be discussed in an issue before creating a PR.
Dart contributions to our repos should follow the Dart style guide and use dart format.
Java and Kotlin contributions should strive to follow Java and Kotlin best practices (discussion).


          [PE] make color picker “dark theme” aware

bf4e432

pq requested a review from jwren

April 23, 2025 22:59

jwren approved these changes

View reviewed changes

pq merged commit 255349f into flutter:master

7 checks passed

pq deleted the pe_colorPickerFix branch

April 23, 2025 23:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet