Skip to content

Add warning about "docked unpinned" state #8247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 6, 2025

Conversation

helin24
Copy link
Member

@helin24 helin24 commented Jun 5, 2025

This threads a potential warning message from an individual tool window (specifically property editor) to an embedded browser tab. There's probably a better way to structure this code, but I've already spent an embarrassing amount of time on shuffling around the UI pieces. 🙃 Suggestions welcome though.

Fixes #8181

Screenshot 2025-06-05 at 3 47 54 PM

@helin24 helin24 force-pushed the toolwindow-warning branch from 2b0e720 to 7497a24 Compare June 5, 2025 22:53
@helin24 helin24 requested review from pq and jwren June 5, 2025 22:53
@helin24
Copy link
Member Author

helin24 commented Jun 5, 2025

CC @elliette

Copy link
Contributor

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🎉

@helin24 helin24 merged commit 6a7750d into flutter:master Jun 6, 2025
7 checks passed
@helin24 helin24 deleted the toolwindow-warning branch June 6, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Dock unpinned" option can be confusing
3 participants