Skip to content

[video_player] Add durationUpdate to VideoEventType #10330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

[video_player] Add durationUpdate to VideoEventType #10330

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
887778e
[video_player] Add updateDuration event
Andro999b Oct 31, 2025
0bbed79
fix: build and unit test name
Andro999b Oct 31, 2025
5e53c3d
Merge branch 'main' into main
Andro999b Oct 31, 2025
209cbd3
update versions and changelogs
Andro999b Oct 31, 2025
547a910
formatting
Andro999b Oct 31, 2025
1df3a54
update version
Andro999b Oct 31, 2025
ed362a6
Merge branch 'main' into main
Andro999b Nov 4, 2025
647df75
Merge branch 'main' into main
Andro999b Nov 5, 2025
8b93c99
Merge branch 'main' into main
Andro999b Nov 7, 2025
bcdcfea
make deps path based
Andro999b Nov 7, 2025
107fbf4
update changelog
Andro999b Nov 7, 2025
e268177
make-deps-path-based
Andro999b Nov 7, 2025
c223c41
fix analyzer errors
Andro999b Nov 7, 2025
eda623e
try fix camera exmaple
Andro999b Nov 7, 2025
0f3cfd4
revert
Andro999b Nov 7, 2025
b649feb
try fix camera example test
Andro999b Nov 7, 2025
4b86c31
revert
Andro999b Nov 7, 2025
ba710b8
Merge branch 'main' into main
Andro999b Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/video_player/video_player/lib/video_player.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,6 +521,8 @@ class VideoPlayerController extends ValueNotifier<VideoPlayerValue> {
value = value.copyWith(isCompleted: true);
case VideoEventType.bufferingUpdate:
value = value.copyWith(buffered: event.buffered);
case VideoEventType.durationUpdate:
value = value.copyWith(duration: event.duration);
case VideoEventType.bufferingStart:
value = value.copyWith(isBuffering: true);
case VideoEventType.bufferingEnd:
Expand Down
21 changes: 21 additions & 0 deletions packages/video_player/video_player/test/video_player_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1049,6 +1049,27 @@ void main() {
expect(controller.value.isBuffering, isFalse);
await tester.runAsync(controller.dispose);
});

testWidgets('buffering status', (WidgetTester tester) async {
final VideoPlayerController controller =
VideoPlayerController.networkUrl(_localhostUri);

await controller.initialize();
const Duration initDuration = Duration(milliseconds: 100);
controller.value = controller.value.copyWith(duration: initDuration);

final StreamController<VideoEvent> fakeVideoEventStream =
fakeVideoPlayerPlatform.streams[controller.playerId]!;

const Duration updatedDuration = Duration(milliseconds: 200);
fakeVideoEventStream.add(
VideoEvent(eventType: VideoEventType.durationUpdate, duration: updatedDuration),
);

await tester.pumpAndSettle();
expect(controller.value.duration, updatedDuration);
await tester.runAsync(controller.dispose);
});
Copy link

@gemini-code-assist gemini-code-assist bot Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The test name 'buffering status' is misleading as this test verifies the duration update functionality. It's also a duplicate of another test name in this file, which can cause confusion. It should be renamed to be more descriptive. Additionally, an extra blank line can be removed for conciseness.

Suggested change
testWidgets('buffering status', (WidgetTester tester) async {
final VideoPlayerController controller =
VideoPlayerController.networkUrl(_localhostUri);
await controller.initialize();
const Duration initDuration = Duration(milliseconds: 100);
controller.value = controller.value.copyWith(duration: initDuration);
final StreamController<VideoEvent> fakeVideoEventStream =
fakeVideoPlayerPlatform.streams[controller.playerId]!;
const Duration updatedDuration = Duration(milliseconds: 200);
fakeVideoEventStream.add(
VideoEvent(eventType: VideoEventType.durationUpdate, duration: updatedDuration),
);
await tester.pumpAndSettle();
expect(controller.value.duration, updatedDuration);
await tester.runAsync(controller.dispose);
});
testWidgets('duration is updated by durationUpdate event', (WidgetTester tester) async {
final VideoPlayerController controller =
VideoPlayerController.networkUrl(_localhostUri);
await controller.initialize();
const Duration initDuration = Duration(milliseconds: 100);
controller.value = controller.value.copyWith(duration: initDuration);
final StreamController<VideoEvent> fakeVideoEventStream =
fakeVideoPlayerPlatform.streams[controller.playerId]!;
const Duration updatedDuration = Duration(milliseconds: 200);
fakeVideoEventStream.add(
VideoEvent(eventType: VideoEventType.durationUpdate, duration: updatedDuration),
);
await tester.pumpAndSettle();
expect(controller.value.duration, updatedDuration);
await tester.runAsync(controller.dispose);
});

});
});

Expand Down