Skip to content

Add /go/go-router-v15-2-0-breaking-changes redirect #12149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2025
Merged

Conversation

chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Jun 23, 2025

breaking change for go_router v15.2.0

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

@chunhtai chunhtai requested review from sfshaza2, antfitch, parlough and a team as code owners June 23, 2025 20:46
@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Jun 23, 2025

Visit the preview URL for this PR (updated for commit 19a7afc):

https://flutter-docs-prod--pr12149-chunhtai-patch-1-511yh1jz.web.app

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link works for me, but looks like the template (and title) aren't filled out yet. Is it the right destination?

I'll approve in case this is just meant as a placeholder.

@@ -456,6 +456,7 @@
{ "source": "/go/go-router-v13-breaking-changes", "destination": "https://docs.google.com/document/d/1FRdW_p29zH0I3KEMQKW_QMMN7owiQ5Wx-PUhhZpehSg/edit?usp=sharing", "type": 301 },
{ "source": "/go/go-router-v14-breaking-changes", "destination": "https://docs.google.com/document/d/1Z6RYo7rGIdtryvQvAntekF53zoz4iy4XvIamBxRWa4Y/edit?usp=sharing&resourcekey=0-CH_yB7ur4gLvSuqPtB5bZA", "type": 301 },
{ "source": "/go/go-router-v15-breaking-changes", "destination": "https://docs.google.com/document/d/1107edi31gPcr4rIbUBvkLqZJiP999ZLI7d85InLbmIw/edit?usp=sharing", "type": 301 },
{ "source": "/go/go-router-v15-2-0-breaking-changes", "destination": "https://docs.google.com/document/d/1SFRO8U2toOlAaZ38dsuEU7Wm5fn41wvBCWKiwADqfmw/edit?usp=sharing", "type": 301 },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chunhtai This seems to lead to the template. Is this intended as a placeholder so the link works or meant to point somewhere else?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops nice catch, I must copied the wrong doc, will fix

@parlough parlough changed the title Update firebase.json Add /go/go-router-v15-2-0-breaking-changes redirect Jun 24, 2025
@chunhtai
Copy link
Contributor Author

let's hold on for a bit before merging, I am talking to the pub.dev team about retracting bad version, the result of that will change the wording of this doc. that is, this may end up becoming migration guide for v16.0.0 instead of v15.2.0

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfshaza2 sfshaza2 merged commit 7426b92 into main Jun 26, 2025
9 checks passed
@sfshaza2 sfshaza2 deleted the chunhtai-patch-1 branch June 26, 2025 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants