-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Add /go/go-router-v15-2-0-breaking-changes
redirect
#12149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Visit the preview URL for this PR (updated for commit 19a7afc): https://flutter-docs-prod--pr12149-chunhtai-patch-1-511yh1jz.web.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link works for me, but looks like the template (and title) aren't filled out yet. Is it the right destination?
I'll approve in case this is just meant as a placeholder.
@@ -456,6 +456,7 @@ | |||
{ "source": "/go/go-router-v13-breaking-changes", "destination": "https://docs.google.com/document/d/1FRdW_p29zH0I3KEMQKW_QMMN7owiQ5Wx-PUhhZpehSg/edit?usp=sharing", "type": 301 }, | |||
{ "source": "/go/go-router-v14-breaking-changes", "destination": "https://docs.google.com/document/d/1Z6RYo7rGIdtryvQvAntekF53zoz4iy4XvIamBxRWa4Y/edit?usp=sharing&resourcekey=0-CH_yB7ur4gLvSuqPtB5bZA", "type": 301 }, | |||
{ "source": "/go/go-router-v15-breaking-changes", "destination": "https://docs.google.com/document/d/1107edi31gPcr4rIbUBvkLqZJiP999ZLI7d85InLbmIw/edit?usp=sharing", "type": 301 }, | |||
{ "source": "/go/go-router-v15-2-0-breaking-changes", "destination": "https://docs.google.com/document/d/1SFRO8U2toOlAaZ38dsuEU7Wm5fn41wvBCWKiwADqfmw/edit?usp=sharing", "type": 301 }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chunhtai This seems to lead to the template. Is this intended as a placeholder so the link works or meant to point somewhere else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops nice catch, I must copied the wrong doc, will fix
/go/go-router-v15-2-0-breaking-changes
redirect
let's hold on for a bit before merging, I am talking to the pub.dev team about retracting bad version, the result of that will change the wording of this doc. that is, this may end up becoming migration guide for v16.0.0 instead of v15.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
breaking change for go_router v15.2.0
Presubmit checklist