Add unmanagedMetadata to canary service specification
#1823
Conversation
briansonnenberg
requested review from
aryan9600 and
stefanprodan
as code owners
|
@stefanprodan @aryan9600 can you give feedback on this CL? |
Done. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1823 +/- ##
===========================================
- Coverage 39.44% 28.98% -10.46%
===========================================
Files 287 287
Lines 22706 22936 +230
===========================================
- Hits 8956 6649 -2307
- Misses 12777 15562 +2785
+ Partials 973 725 -248 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Please add this field to the docs here https://docs.flagger.app/usage/how-it-works#canary-service
These are labels and annotations that should be ignored by Flagger (i.e. not overwritten upon reconciliation). See: github.com/fluxcd/issues/1573 Signed-off-by: Brian Sonnenberg <[email protected]>
|
@stefanprodan @aryan9600 I've updated the API to be "unmanagedMetadata", and support both annotations and labels. Also updated the docs to mention this. |
stefanprodan
changed the title
unmanagedMetadata to canary service specification
|
Just to note that this PR does not solve the original issue. While we preserve the metadata on Kubernetes Services, we are still removing unmanaged labels and annotations from Istio & Gateway API objects. |
stefanprodan
added
the
kind/enhancement
5 participants
Unmanaged labels and annotations present on Kubernetes Services are to be ignored by Flagger (i.e. not overwritten / removed upon reconciliation).
See: here