Skip to content

Conversation

@stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Oct 7, 2025

Changes:

  • Update build system to Go 1.25
  • Update dependencies to Kubernetes 1.34
  • Regenerate clientset with Kubernetes 1.34 code-gen

Closes: #1802

@stefanprodan stefanprodan added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Oct 7, 2025
@cappyzawa
Copy link
Member

I noticed a couple of potential updates that might be worth considering:

  1. docs/gitbook/dev/dev-guide.md

    • Currently states go >= 1.19
    • Should this be updated to go >= 1.25, or perhaps removed entirely since the version requirement is already specified in go.mod?
  2. .github/workflows/e2e.yaml

    • The kindest/node images are currently using Kubernetes 1.30.0 and 1.24.12
    • Should these be updated to align with Kubernetes 1.34, or is keeping them at 1.30.0 intentional for testing compatibility?

@stefanprodan
Copy link
Member Author

@cappyzawa changing the Kubernetes version will break some of the e2e tests. The version of the service meshes and gateway controllers need to updated along with Kubernetes for this to work.

I will bump the Go version in docs, thanks for the review!

Copy link
Member

@aryan9600 aryan9600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending the merge conflict resolution!

@stefanprodan stefanprodan merged commit 3dc0658 into main Oct 15, 2025
18 checks passed
@stefanprodan stefanprodan deleted the go1.25 branch October 15, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants