Remove unnecessary arguments for log(...) #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to specify PID in the public log(...) function because logd obtains it from the credentials ([0]), which we don't fill explicitly (no stable api in Rust for that now). However, in our case (logdw socket has enabled passcred option) the kernel does it automatically ([1]). We also shouldn't pass TID (in public log(...)) because we always use our thread id for that purpose. [0] https://chromium.googlesource.com/aosp/platform/system/logging/+/refs/heads/factory-ambassador-14265.B/logd/LogListener.cpp#119 [1] https://elixir.bootlin.com/linux/v6.5/source/net/unix/af_unix.c#L1857
flxo
reviewed
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to specify PID in the public log(...) function because logd obtains it from the credentials ([0]), which we don't fill explicitly (no stable api in Rust for that now). However, in our case (logdw socket has enabled passcred option) the kernel does it automatically ([1]).
We also shouldn't pass TID (in public log(...)) because we always use our thread id for that purpose.
[0] https://chromium.googlesource.com/aosp/platform/system/logging/+/refs/heads/factory-ambassador-14265.B/logd/LogListener.cpp#119
[1] https://elixir.bootlin.com/linux/v6.5/source/net/unix/af_unix.c#L1857