Skip to content

Install only production dependencies using Bun #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

neanias
Copy link
Contributor

@neanias neanias commented May 19, 2025

This could be extended to the other major JS providers too, but that
might be out of scope for this.

This could be extended to the other major JS providers too, but that
might be out of scope for this.
@rubys
Copy link
Collaborator

rubys commented May 19, 2025

Cool! Possibly related: oven-sh/bun#3605

@neanias
Copy link
Contributor Author

neanias commented May 19, 2025

Oh, interesting! I wonder which is the more useful way around in this case 🤔

@neanias
Copy link
Contributor Author

neanias commented May 19, 2025

I'm not clear what's actually failing in these tests. The postgres tests seem unrelated?

@rubys
Copy link
Collaborator

rubys commented May 19, 2025

Note that that issue is still unresolved. The desire is that the end result is that only production dependencies are installed in the final image. I'm fine if the way to achieve that result varies by packaging tool. In fact, it seems necessarily so.

As to Postgres, it looks like Rails recently changed and the test case simply needs to be updated to match: rails/rails@de9dd40 ; that need not hold up this pull request.

@neanias
Copy link
Contributor Author

neanias commented May 19, 2025

I'm happy to add some other packaging tools as part of this PR whilst I'm at it if you'd like?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants