-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(a380x/fctl): Protection speeds improvements after flight model update #9694
Merged
flogross89
merged 24 commits into
flybywiresim:master
from
flogross89:fix-a380x-fac-alpha-after-don
Mar 19, 2025
Merged
fix(a380x/fctl): Protection speeds improvements after flight model update #9694
flogross89
merged 24 commits into
flybywiresim:master
from
flogross89:fix-a380x-fac-alpha-after-don
Mar 19, 2025
+2,760
−2,465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2c3ace7
to
287cd2e
Compare
9062486
to
9583e06
Compare
# Conflicts: # fbw-a380x/src/systems/shared/src/OperatingSpeeds.tsx
lukecologne
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
# Conflicts: # fbw-a380x/src/systems/instruments/src/PFD/FMA.tsx
# Conflicts: # fbw-a380x/src/systems/instruments/src/PFD/FMA.tsx # fbw-a380x/src/wasm/fbw_a380/src/FlyByWireInterface.cpp # fbw-a380x/src/wasm/fbw_a380/src/FlyByWireInterface.h
Quality Assurance Trainee Report Discord Username : jonny_23 Testing Process:
Testing Results: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9689
Fixes #8725
Fixes #9846
Summary of Changes
Screenshots (if necessary)
vs

vs
vs
PFD direct law indications:

References
https://www.youtube.com/watch?v=hDh_9MEz-hg
https://www.youtube.com/watch?v=AI8yFhuEa4Q
https://www.youtube.com/watch?v=pHui34_ODnc
https://www.youtube.com/watch?v=qcXQKQukxkI&t=284s
https://www.youtube.com/watch?v=DtIF26FEZug&t=338s
Additional context
Note for reviewer: Only alpha max and alpha protection look-up tables were modified in the MATLAB models, no MATLAB review needed.
Current alpha tables:

alpha_max:
alpha_prot:

new alpha_0 table:

Discord username (if different from GitHub): floridude
Testing instructions
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.