poc for 2024 wasm #33
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saschl
commented
Mar 26, 2025
| sys::fsVarsAircraftVarGet(self.simvar, self.units, params_for_get, &mut v); | ||
|
|
||
| // drop the mem | ||
| drop(Box::from_raw(params_for_get.array)); |
There was a problem hiding this comment.
I guess the drop is not needed here. I experimented a lot as I initially thought some of the issues I encountered were caused by memory issues, but that was not the case.
Saschl
commented
Mar 26, 2025
|
|
||
| array.push(sys::FsVarParamVariant { | ||
| type_: sys::eFsVarParamType_FsVarParamTypeInteger, | ||
| __bindgen_anon_1: sys::FsVarParamVariant__bindgen_ty_1 { |
There was a problem hiding this comment.
Ugly, but that's what bindgen gives us here. Guess it happens because there's no anonymous unions in rust
Saschl
commented
Mar 26, 2025
| }); | ||
|
|
||
| let params_for_set = sys::FsVarParamArray { | ||
| size: 1, |
There was a problem hiding this comment.
Can hold more than one obviously :D Was enough for our use case, but should be handled properly
Saschl
commented
Mar 26, 2025
| }; | ||
|
|
||
| self.executor.send(Some(data)).unwrap(); | ||
| /* sys::PANEL_SERVICE_POST_KILL => self.executor.send(None).is_ok(), |
There was a problem hiding this comment.
Can be removed for 2024 systems as the callbacks are separated now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just for information, it's not complete and breaks 2020 compatibility