Draft
Conversation
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Custom Dockerfile installs python-build-standalone, stubs the libs pg-glibc is missing (libutil/libnsl/libresolv), and points SSL_CERT_FILE at the bundled CA bundle so pyqwest can talk to the control plane. App env runs the base k3d entrypoint and requests a privileged pod via PodTemplate. Note: Union control plane currently drops securityContext before it reaches Knative, so the privileged request is a no-op. Tracking separately; this PR is for review of the image/app plumbing only. Signed-off-by: Kevin Su <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dockerfile.flyte_binaryto makeghcr.io/flyteorg/flyte-demo:nightlyusable as an app base — k3s rootfs has no/usr/bin, static busybox, and only a partial glibc bundled for Postgres. Installs python-build-standalone, stubslibutil/libnsl/libresolv(merged into libc in glibc 2.34+), setsSSL_CERT_FILE/SSL_CERT_DIRsopyqwestcan load CA certs.flyte_binary_app.pywires the image viaImage.from_dockerfile(...), setscommand=["/bin/k3d-entrypoint.sh", ...], and attaches aPodTemplaterequestingprivileged=true+SYS_ADMIN/NET_ADMIN.Status — WIP
flyteimports cleanly.PodTemplatesecurityContextis present in the Union app spec but is silently stripped before reaching the Knative Configuration — Knative generation never advances after the privileged deploy. So the privileged request is a no-op on this tenant.Test plan
/sys/fs/cgroup,/lib/modules,/var/lib/rancher).securityContextin the app control plane.