[v2][Feat] Add the check-generate workflow can work in local runner for the PR from fork repo (#6845)#7040
[v2][Feat] Add the check-generate workflow can work in local runner for the PR from fork repo (#6845)#7040SZL741023 wants to merge 15 commits intoflyteorg:v2from
Conversation
Adjust check-generate workflow that will call other workflows and check other workflows will be failure or not Separate original check-generate workflow to check-generate-container.yml and rename to check-generate-container Add new workflow file check-generate-local.yml for the PR from fork repo Signed-off-by: SZL741023 <[email protected]>
If the PR from fork repo, don't to rebuild the ci image Signed-off-by: SZL741023 <[email protected]>
machichima
left a comment
There was a problem hiding this comment.
LGTM! Just a small nit. Also, please fix the merge conflict
Thank you!
Signed-off-by: SZL741023 <[email protected]>
Signed-off-by: SZL741023 <[email protected]>
Signed-off-by: SZL741023 <[email protected]>
| echo "buf=$(extract BUF_VERSION)" >> $GITHUB_OUTPUT | ||
| echo "mockery=$(extract MOCKERY_VERSION)" >> $GITHUB_OUTPUT | ||
|
|
||
| check-generate: |
There was a problem hiding this comment.
There was a problem hiding this comment.
Both CI job check-go-tidy and check-mock also need to use the same container, so they also need to be run separately in the container and local environments.
But as per discussion, we got the new solution, if the pr from fork, build a new image to github action storage and then use it to run check-generate , check-go-tidy , check-mock
I will adjust it later.
machichima
left a comment
There was a problem hiding this comment.
LGTM! Thank you!
cc @pingsutw for final pass
Add the job to build image for fork PR. According the PR to choice local image or ghcr.io image. Signed-off-by: SZL741023 <[email protected]>
Merge branch 'v2' of https://github.com/flyteorg/flyte into v2_git_workflows_dev Signed-off-by: SZL741023 <[email protected]>
Signed-off-by: SZL741023 <[email protected]>
Signed-off-by: SZL741023 <[email protected]>
Signed-off-by: SZL741023 <[email protected]>
|
Adjust the workflow, if the PR is from fork repo, it will build a local image to github storage, then do |
… fork PR Allow the fork PR that modified the gen.Dockerfile can push the new image to ghcr.io. Signed-off-by: SZL741023 <[email protected]>
Signed-off-by: SZL741023 <[email protected]>
Signed-off-by: SZL741023 <[email protected]>
Signed-off-by: SZL741023 <[email protected]>
Signed-off-by: SZL741023 <[email protected]>
|
New pr for this issue is #7336 |

Tracking issue
Related to: (#6845)
Original PR: (#6952)
Why are the changes needed?
In original work flow, if files
gen.Dockerfileandbuild-ci-image.ymlhave been changed, the action for build ci image will be trigger. The action for check generation will be exercise after a new ci image is built.If the PR from fork repo, the ci image should not be rebuild and the check generate will be run in local runner.
What changes were proposed in this pull request?
build-ci-image.ymladd the condition to check the PR is from the same repo or fork repo.If PR is from fork repo, build ci image will be skip.
check-generation.ymladd the condition to check the PR is from fork repo or not, and addneeds: [check-generate-conatiner, check-generate-local]to call these workflows with the check fork repo condition and monitor these workflow will be failure or not.Add two workflows files
check-generate-container.ymlandcheck-generate-local.ymlfile and trigger by workflow call.One does check generate in container, the other one does check generate in local runner.
Add the
extract()function incheck-generate-local.ymlto extract the tool versions from gen.Dockerfile to ensure that the correct version information is used.How was this patch tested?
Ensure the PR from fork repo will not trigger the action for build ci image, and check generation will be run in locally runner.
Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
mainmake genmore robust #6845) 👈