Skip to content

ci: switch ci trigger to pull_request_target for check-generate workflow#7336

Merged
pingsutw merged 1 commit intoflyteorg:mainfrom
SZL741023:main_ciworkflow_dev
May 2, 2026
Merged

ci: switch ci trigger to pull_request_target for check-generate workflow#7336
pingsutw merged 1 commit intoflyteorg:mainfrom
SZL741023:main_ciworkflow_dev

Conversation

@SZL741023
Copy link
Copy Markdown
Contributor

Tracking issue

Related to: (#6845)

Why are the changes needed?

Because the fork PR doesn't have permission to push the ci image to ghcr.io when it is built with the related files are changed.
So change the workflow trigger to pull_request_target.

What changes were proposed in this pull request?

check-generate.yml

  • Changed the workflow trigger to pull_request_target in check-generate.yml.
  • Add other method to find the pr and check if it is running.
  • Add ref in check code to use the code from head repo.

How was this patch tested?

Test by the workflow being trigger in ci process.

Labels

Please add one or more of the following labels to categorize your PR:

  • added: For new features.
  • changed: For changes in existing functionality.
  • deprecated: For soon-to-be-removed features.
  • removed: For features being removed.
  • fixed: For any bug fixed.
  • security: In case of vulnerabilities

This is important to improve the readability of release notes.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Original PR: #6952 #7040

Stack

If you do use git town to manage PR Stacks, the stack relevant to this PR
will show below. Otherwise, you can ignore this section.

Docs link

switch the ci trigger fo check-generate workflow, adjust the method to
get prRun, if can't find pr number in pull request event, then use sha
to find the commit.

Signed-off-by: SZL741023 <[email protected]>
@github-actions github-actions Bot added the flyte2 label May 2, 2026
@pingsutw pingsutw added this to the V2 GA milestone May 2, 2026
@pingsutw pingsutw merged commit 4b2c903 into flyteorg:main May 2, 2026
17 checks passed
@SZL741023 SZL741023 deleted the main_ciworkflow_dev branch May 2, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants