Skip to content

Doc: Explain how to chain launch plans#6317

Merged
fg91 merged 2 commits intomasterfrom
fg91/doc/chain-launchplans
Mar 24, 2025
Merged

Doc: Explain how to chain launch plans#6317
fg91 merged 2 commits intomasterfrom
fg91/doc/chain-launchplans

Conversation

@fg91
Copy link
Copy Markdown
Member

@fg91 fg91 commented Mar 8, 2025

Why are the changes needed?

We currently don't provide an example for launch plan chaining in the docs and users asked me about this.
See added example in flyteorg/flytesnacks#1783.

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

flyteorg/flytesnacks#1783

Docs link

@fg91 fg91 requested a review from ppiegaze as a code owner March 8, 2025 10:57
@fg91 fg91 self-assigned this Mar 8, 2025
@fg91 fg91 added the documentation Improvements or additions to documentation label Mar 8, 2025
@flyte-bot
Copy link
Copy Markdown
Collaborator

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at [email protected].

@fg91 fg91 requested review from neverett and pingsutw March 8, 2025 10:58
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.48%. Comparing base (754ab74) to head (f651142).
Report is 53 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6317      +/-   ##
==========================================
- Coverage   58.48%   58.48%   -0.01%     
==========================================
  Files         940      940              
  Lines       71567    71567              
==========================================
- Hits        41858    41857       -1     
- Misses      26525    26526       +1     
  Partials     3184     3184              
Flag Coverage Δ
unittests-datacatalog 59.03% <ø> (ø)
unittests-flyteadmin 56.28% <ø> (ø)
unittests-flytecopilot 30.99% <ø> (ø)
unittests-flytectl 64.70% <ø> (ø)
unittests-flyteidl 76.12% <ø> (ø)
unittests-flyteplugins 60.89% <ø> (ø)
unittests-flytepropeller 54.81% <ø> (ø)
unittests-flytestdlib 64.02% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Fabio Grätz added 2 commits March 24, 2025 19:21
Signed-off-by: Fabio Grätz <[email protected]>
@fg91 fg91 force-pushed the fg91/doc/chain-launchplans branch from 1ddb7a5 to f651142 Compare March 24, 2025 18:25
@fg91 fg91 requested a review from thomasjpfan March 24, 2025 18:26
@flyte-bot
Copy link
Copy Markdown
Collaborator

flyte-bot commented Mar 24, 2025

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at [email protected].

@fg91 fg91 merged commit 50a67f8 into master Mar 24, 2025
51 checks passed
@fg91 fg91 deleted the fg91/doc/chain-launchplans branch March 24, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants