Aborting forever and untriggerd on_failure node when aborting failure caused by UserError#6749
Aborting forever and untriggerd on_failure node when aborting failure caused by UserError#67490yukali0 wants to merge 1 commit into
Conversation
|
Bito Automatic Review Skipped - Draft PR |
0yukali0
changed the title
0yukali0
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6749 +/- ##
==========================================
+ Coverage 57.16% 58.26% +1.10%
==========================================
Files 925 710 -215
Lines 57823 42362 -15461
==========================================
- Hits 33052 24682 -8370
+ Misses 21753 15441 -6312
+ Partials 3018 2239 -779
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@0yukali0 thanks for contributing. Any help you need? |
|
@davidmirror-ops |
| if mutableW.Status.FailedAttempts == maxRetries { | ||
| var err error | ||
| _ = controllerutil.AddFinalizer(mutableW, Finalizer) | ||
| SetDefinitionVersionIfEmpty(mutableW, v1alpha1.LatestWorkflowDefinitionVersion) | ||
|
|
||
| func() { | ||
| t := p.metrics.RawWorkflowTraversalTime.Start(ctx) | ||
| defer func() { | ||
| t.Stop() | ||
| if r := recover(); r != nil { | ||
| stack := debug.Stack() | ||
| err = fmt.Errorf("panic when reconciling workflow, Stack: [%s]", string(stack)) | ||
| logger.Errorf(ctx, err.Error()) | ||
| p.metrics.PanicObserved.Inc(ctx) | ||
| } | ||
| }() | ||
| err = p.workflowExecutor.HandleFlyteWorkflow(ctx, mutableW) | ||
| }() | ||
| if err != nil { | ||
| logger.Errorf(ctx, "Error when trying to reconcile workflow. Error [%v]. Error Type[%v]", | ||
| err, reflect.TypeOf(err)) | ||
| p.metrics.SystemError.Inc(ctx) | ||
| return nil, err | ||
| } |
There was a problem hiding this comment.
Do you mind explain a bit why we need this here?
Signed-off-by: Yuteng Chen <a08h0283@gmail.com>
|
UserCodeError triggers the On_failure node and enter to the failed state. |
4 participants
Tracking issue
#6695
Why are the changes needed?
What changes were proposed in this pull request?
How was this patch tested?
Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link