Upgrade spark-operator to v2.1.1#6865
Merged
pingsutw merged 21 commits intoApr 30, 2026
Merged
Conversation
Signed-off-by: Kevin Liao <q85292542000@gmail.com>
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6865 +/- ##
==========================================
- Coverage 56.96% 56.96% -0.01%
==========================================
Files 931 931
Lines 58275 58276 +1
==========================================
- Hits 33199 33198 -1
- Misses 22017 22019 +2
Partials 3059 3059
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Update viper to v1.11.0 in every affected go.mod, resolving previous update that only covered one subproject. Signed-off-by: Kevin Liao <q85292542000@gmail.com>
Signed-off-by: Kevin Liao <q85292542000@gmail.com>
Signed-off-by: Kevin Liao <q85292542000@gmail.com>
…ired Signed-off-by: Kevin Liao <q85292542000@gmail.com>
Signed-off-by: Kevin Liao <q85292542000@gmail.com>
machichima
reviewed
Feb 13, 2026
Member
machichima
left a comment
machichima
left a comment
There was a problem hiding this comment.
Overall LGTM, just a few comments
| } | ||
|
|
||
| if sparkJob.GetExecutorPath() != "" { | ||
| if sparkJob.GetExecutorPath() != "" && sparkConfig["spark.pyspark.python"] == "" && sparkConfig["spark.pyspark.driver.python"] == "" { |
Member
There was a problem hiding this comment.
Could you add the changes here to the PR description?
Contributor
Author
There was a problem hiding this comment.
I rechecked this logic and realized the current conditional handling could be problematic. I’d prefer to revert to the previous behavior for now. Let me know if you see any concerns.
Contributor
Author
|
As discussed with @pingsutw , we should run the tests against the v1 CRD to match the currently compatible operator version. |
Signed-off-by: Kevin Liao <q85292542000@gmail.com>
…tor-2.1.1 Signed-off-by: Kevin Liao <q85292542000@gmail.com>
Signed-off-by: Kevin Liao <q85292542000@gmail.com>
Signed-off-by: Kevin Liao <q85292542000@gmail.com>
pingsutw
previously approved these changes
Apr 13, 2026
pingsutw
changed the title
…tor-2.1.1 Signed-off-by: Kevin Liao <q85292542000@gmail.com>
Signed-off-by: Kevin Liao <q85292542000@gmail.com>
Signed-off-by: Kevin Liao <q85292542000@gmail.com>
Signed-off-by: Kevin Liao <q85292542000@gmail.com>
…tor-2.1.1 Signed-off-by: Kevin Liao <q85292542000@gmail.com>
kevinliao852
changed the title
pingsutw
previously approved these changes
Apr 18, 2026
…tor-2.1.1 Signed-off-by: Kevin Liao <q85292542000@gmail.com>
pingsutw
previously approved these changes
Apr 30, 2026
…tor-2.1.1 Signed-off-by: Kevin Liao <q85292542000@gmail.com>
pingsutw
approved these changes
Apr 30, 2026
nuthalapativarun
pushed a commit
to nuthalapativarun/flyte
that referenced
this pull request
May 1, 2026
Signed-off-by: Kevin Liao <q85292542000@gmail.com> Co-authored-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Varun Nuthalapati <nuthalapativarun@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Related #6686, #6348
Why are the changes needed?
What changes were proposed in this pull request?
How was this patch tested?
Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link