Skip to content

added: update to contributing file#7182

Merged
Sovietaced merged 4 commits into
flyteorg:masterfrom
Honyii:update-contributing-file
Apr 29, 2026
Merged

added: update to contributing file#7182
Sovietaced merged 4 commits into
flyteorg:masterfrom
Honyii:update-contributing-file

Conversation

@Honyii
Copy link
Copy Markdown

@Honyii Honyii commented Apr 9, 2026

Tracking issue

closes #7165

Why are the changes needed?

  • To improve the contributing guidelines for clarity

What changes were proposed in this pull request?

The changes I am proposing is to answer the question of; I want to contribute, how do I start and also highlightign other contributor paths like documentation and design.

How was this patch tested?

Tests were not aded because this is a .md file and isn't causing a breaking change.

Labels

Please add one or more of the following labels to categorize your PR:

  • added: For new features.
  • changed: For changes in existing functionality.

This is important to improve the readability of release notes.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

General questions that may require clarification/how to proceed

  • In the COC and reporting security bugs section, how do contributors report unacceptable behaviour/security issues. Right now I have a send to [email] but no email address for it to be sent to.
  • The slack channel link I referenced in the file, can you share one that does not expire? I am guessing the one I copied from my end may have an expiration date.
  • For the recommendation order, is there a preferred order than the one I have currently?

Kindly let me know if this aligns to the project's needs/ the cprrect way to reference appropriate channels.

@welcome
Copy link
Copy Markdown

welcome Bot commented Apr 9, 2026

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.96%. Comparing base (73ec67a) to head (401f7f1).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7182   +/-   ##
=======================================
  Coverage   56.96%   56.96%           
=======================================
  Files         931      931           
  Lines       58275    58275           
=======================================
  Hits        33197    33197           
  Misses      22019    22019           
  Partials     3059     3059           
Flag Coverage Δ
unittests-datacatalog 53.51% <ø> (ø)
unittests-flyteadmin 53.15% <ø> (ø)
unittests-flytecopilot 43.06% <ø> (ø)
unittests-flytectl 64.09% <ø> (ø)
unittests-flyteidl 75.71% <ø> (ø)
unittests-flyteplugins 60.19% <ø> (ø)
unittests-flytepropeller 53.71% <ø> (ø)
unittests-flytestdlib 62.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Honyii Honyii force-pushed the update-contributing-file branch from ad49d1e to 6686d47 Compare April 13, 2026 20:24
ppiegaze
ppiegaze previously approved these changes Apr 14, 2026
Copy link
Copy Markdown
Member

@ppiegaze ppiegaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ppiegaze
Copy link
Copy Markdown
Member

ppiegaze commented Apr 14, 2026

@Honyii The Slack channel is fine
For the email address, please use [email protected] (I know, it should be security, but it will get to the right person)
For the DCO thing do this:

git rebase HEAD~N --signoff
git push --force-with-lease

(where N is the number of commits in the PR)

Honyii added 4 commits April 30, 2026 06:11
Signed-off-by:amaechi hope [email protected]

Signed-off-by: amaechi hope <[email protected]>
Signed-off-by: amaechi hope [email protected]

Signed-off-by: amaechi hope <[email protected]>
Signed-off-by:  amaechi hope [email protected]

Signed-off-by: amaechi hope <[email protected]>
@Sovietaced Sovietaced force-pushed the update-contributing-file branch from 49f3e05 to 401f7f1 Compare April 29, 2026 22:11
@github-actions github-actions Bot added the flyte label Apr 29, 2026
@Sovietaced Sovietaced enabled auto-merge (squash) April 29, 2026 22:11
@Sovietaced Sovietaced added the documentation Improvements or additions to documentation label Apr 29, 2026
@Sovietaced Sovietaced merged commit 91d6af1 into flyteorg:master Apr 29, 2026
50 checks passed
nuthalapativarun pushed a commit to nuthalapativarun/flyte that referenced this pull request May 1, 2026
* added: update to contributing file
Signed-off-by:amaechi hope [email protected]

Signed-off-by: amaechi hope <[email protected]>

* update typo
Signed-off-by: amaechi hope [email protected]

Signed-off-by: amaechi hope <[email protected]>

* uodate text content#
Signed-off-by:  amaechi hope [email protected]

Signed-off-by: amaechi hope <[email protected]>

* hotfix: update email address

Signed-off-by: amaechi hope <[email protected]>

---------

Signed-off-by: amaechi hope <[email protected]>
Signed-off-by: Varun Nuthalapati <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation flyte

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve the contribution guidelines

4 participants