Skip to content

use Helm to init rustfs in sandbox#7233

Open
BarryWu0812 wants to merge 9 commits intoflyteorg:v2from
BarryWu0812:#7209
Open

use Helm to init rustfs in sandbox#7233
BarryWu0812 wants to merge 9 commits intoflyteorg:v2from
BarryWu0812:#7209

Conversation

@BarryWu0812
Copy link
Copy Markdown
Contributor

@BarryWu0812 BarryWu0812 commented Apr 18, 2026

Tracking issue

Closes #7209

Why are the changes needed?

According to rustfs doc, we can run it with helm chart instead of scripting the yaml on our own.
We run an init container to create default bucket now because rustfs do not support default bucket config now. After migrating to helmchart, we can run a k8s post-install Job to create default bucket.

What changes were proposed in this pull request?

Use Helm to init rustfs in sandbox and run k8s post-install Job to create default bucket.

How was this patch tested?

Run make sandbox-build.
Run an example workflow and make sure the result is success.

Labels

Please add one or more of the following labels to categorize your PR:

  • added: For new features.
  • changed: For changes in existing functionality.
  • deprecated: For soon-to-be-removed features.
  • removed: For features being removed.
  • fixed: For any bug fixed.
  • security: In case of vulnerabilities

This is important to improve the readability of release notes.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Copy link
Copy Markdown
Contributor

@popojk popojk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, thanks! Left a few comments, PTAL

Comment thread charts/flyte-devbox/values.yaml
Comment thread charts/flyte-devbox/templates/storage/rustfs-bucket-init-job.yaml Outdated
Comment thread charts/flyte-devbox/templates/storage/rustfs-bucket-init-job.yaml Outdated
Comment thread charts/flyte-devbox/values.yaml
Comment thread docker/demo-bundled/Makefile Outdated
@popojk
Copy link
Copy Markdown
Contributor

popojk commented Apr 28, 2026

Hey @BarryWu0812 .

  1. I still saw a rustfs init pod created on routine basis, could you please check it?
  2. Please rebase this PR after 1st item resolved

Copy link
Copy Markdown
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add new path (/rustfs) to the ingress rules for the rustfs console and make sure it’s accessible from the browser?

kind: Ingress
metadata:
name: flyte-console
namespace: {{ .Release.Namespace | quote }}
labels: {{- include "flyte-devbox.labels" . | nindent 4 }}
spec:
rules:
- http:
paths:
- path: /v2
pathType: Prefix
backend:
service:
name: flyte-console
port:
number: 80
{{- end }}
---

containers:
- name: bucket-init
image: "{{ .Values.rustfs.bucketInit.image.repository }}:{{ .Values.rustfs.bucketInit.image.tag }}"
imagePullPolicy: {{ .Values.rustfs.bucketInit.image.pullPolicy }}
Copy link
Copy Markdown
Member

@pingsutw pingsutw Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a patch to complete/dev kustomization.yaml to add an init container to the rustfs deployment, so that we don't need to add docker.io/minio/mc:latest and another k8s job into the devbox

- patch: |-
    apiVersion: apps/v1
    kind: Deployment
    metadata:
      name: rustfs
      namespace: flyte
    spec:
      template:
        spec:
          initContainers:
          - name: create-default-buckets
            image: busybox:stable
            imagePullPolicy: IfNotPresent
            command:
            - sh
            - -c
            - mkdir -p /data/flyte-data
            securityContext:
              allowPrivilegeEscalation: false
              capabilities:
                drop:
                - ALL
              readOnlyRootFilesystem: true
              runAsNonRoot: true
            volumeMounts:
            - mountPath: /data
              name: data

@BarryWu0812 BarryWu0812 changed the base branch from v2 to main April 29, 2026 05:00
@BarryWu0812 BarryWu0812 changed the base branch from main to v2 April 29, 2026 06:42
@BarryWu0812 BarryWu0812 changed the base branch from v2 to main April 29, 2026 06:45
@BarryWu0812 BarryWu0812 changed the base branch from main to v2 April 29, 2026 06:46
@BarryWu0812 BarryWu0812 changed the base branch from v2 to main April 29, 2026 06:50
@BarryWu0812 BarryWu0812 changed the base branch from main to v2 April 29, 2026 06:51
@BarryWu0812 BarryWu0812 changed the base branch from v2 to main April 29, 2026 06:54
@BarryWu0812 BarryWu0812 requested a review from pingsutw April 29, 2026 07:15
@BarryWu0812 BarryWu0812 changed the base branch from main to v2 April 29, 2026 15:14
@BarryWu0812
Copy link
Copy Markdown
Contributor Author

Hi @popojk @pingsutw , I have create new PR based on main branch. Please help me to review. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[V2] use Helm to init rustfs in sandbox

3 participants