Skip to content

Allow routing secrets endpoints via SelectCluster #7245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
katrogan wants to merge 5 commits into
base: v2
Choose a base branch
from
Open

Allow routing secrets endpoints via SelectCluster #7245

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c62e15a
Add secrets operations to SelectCluster
katrogan Apr 21, 2026
dafa1fe
simpler
katrogan Apr 21, 2026
dd70709
regen
katrogan Apr 21, 2026
41b3226
domain too
katrogan Apr 21, 2026
310c1f7
merge v2
katrogan Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions flyteidl2/cluster/payload.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ message SelectClusterRequest {
flyteidl2.common.ActionIdentifier action_id = 4;
flyteidl2.common.ActionAttemptIdentifier action_attempt_id = 5;
flyteidl2.app.Identifier app_id = 6;
flyteidl2.common.DomainIdentifier domain_id = 9;
}

enum Operation {
Expand All @@ -29,6 +30,7 @@ message SelectClusterRequest {
OPERATION_CREATE_DOWNLOAD_LINK = 5;
OPERATION_TAIL_LOGS = 6;
OPERATION_GET_ACTION_ATTEMPT_METRICS = 7;
OPERATION_USE_SECRETS = 10;
}

Operation operation = 8 [(buf.validate.field).enum = {
Expand Down
5 changes: 5 additions & 0 deletions flyteidl2/common/identifier.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@ message ProjectIdentifier {
string name = 3 [(buf.validate.field).string.min_len = 1];
}

message DomainIdentifier {
string organization = 1 [(buf.validate.field).string.min_len = 1];
string name = 2 [(buf.validate.field).string.min_len = 1];
}

message ClusterIdentifier {
string organization = 1;
string name = 2 [(buf.validate.field).string.min_len = 1];
Expand Down
142 changes: 84 additions & 58 deletions gen/go/flyteidl2/cluster/payload.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

41 changes: 41 additions & 0 deletions gen/go/flyteidl2/cluster/payload.pb.validate.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading