[V2] Add App events#7296
Closed
machichima wants to merge 8 commits intoflyteorg:v2from
Closed
Conversation
Signed-off-by: machichima <[email protected]>
Signed-off-by: machichima <[email protected]>
Signed-off-by: machichima <[email protected]>
Signed-off-by: machichima <[email protected]>
Signed-off-by: machichima <[email protected]>
Signed-off-by: machichima <[email protected]>
Signed-off-by: machichima <[email protected]>
Signed-off-by: machichima <[email protected]>
pingsutw
reviewed
Apr 28, 2026
|
|
||
| // RunMigrations applies all pending app migrations. | ||
| func RunMigrations(ctx context.Context, db *sqlx.DB) error { | ||
| return database.Migrate(ctx, db, "app", migrationFS) |
Member
There was a problem hiding this comment.
We intentionally don’t use the database in the app service for simplicity. Could we directly get the events from the CRD when watching the events
Member
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
In this case we will miss historical conditions as k8s conditions will only store the latest state
Conditions:
Last Transition Time: 2026-04-28T07:41:44Z
Status: True
Type: ConfigurationsReady
Last Transition Time: 2026-04-28T07:41:44Z
Status: True
Type: Ready
Last Transition Time: 2026-04-28T07:41:44Z
Status: True
Type: RoutesReady
Member
There was a problem hiding this comment.
we will miss historical conditions
that's okay
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Why are the changes needed?
Show APP events
What changes were proposed in this pull request?
app_conditionstable in DB to store conditions (events) for appHow was this patch tested?
Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
main