ci: add DCO config to allow remediation commits#7297
Merged
Conversation
Configures the Probot DCO app to permit individual and third-party remediation commits, enabling sign-off backfill for branches with historical commits that lack matching Signed-off-by lines. Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7297 +/- ##
=======================================
Coverage 56.96% 56.96%
=======================================
Files 931 931
Lines 58272 58272
=======================================
Hits 33195 33195
Misses 22018 22018
Partials 3059 3059
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cosmicBboy
approved these changes
Apr 28, 2026
This was referenced Apr 28, 2026
nuthalapativarun
pushed a commit
to nuthalapativarun/flyte
that referenced
this pull request
May 1, 2026
Configures the Probot DCO app to permit individual and third-party remediation commits, enabling sign-off backfill for branches with historical commits that lack matching Signed-off-by lines. Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> Signed-off-by: Varun Nuthalapati <nuthalapativarun@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/dco.ymlconfiguring the Probot DCO app to allow remediation commits.individual(a contributor signing off their own past commits) andthirdParty(someone else signing off on a contributor's behalf) remediation modes.Why
The Probot DCO app reads its config from the default branch, so this needs to land on
masterfirst before remediation commits on other branches will be honored. The immediate motivation is thev2 → mainintegration PR (#6583), which has 133 commits across ~20 authors flagged for missing/mismatched sign-offs and cannot be cleanly resolved bygit rebase --signoff(the default fix the bot suggests works only when the PR author is the sole contributor).Behavior
Signed-off-by:per commit (default strict check unchanged for normal flow).Test plan