Skip to content

feat(proto): add task_type to TailLogsRequest for connector log routing #7313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pingsutw wants to merge 1 commit into from
Closed

feat(proto): add task_type to TailLogsRequest for connector log routing #7313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions flyteidl2/dataproxy/dataproxy_service.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,14 @@ message TailLogsRequest {

// The pod name to tail logs from. If not provided, attempt to find the primary pod, else assume the first pod.
string pod_name = 3;

// +optional. Connector task type name (e.g. "airflow", "batch_job"). When set, the dataplane operator
// routes the request to the matching connector's GetTaskLogs RPC instead of pod logs. The UI populates
// this from the task template it already loaded for the run.
string task_type = 4;

// +optional. Connector task type version. Used together with task_type to identify a TaskCategory.
int32 task_type_version = 5;
Comment on lines +209 to +215
Copy link

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These new fields update the .proto sources, but the non-Go generated bindings appear not to be regenerated/committed (e.g. gen/ts and gen/python TailLogsRequest types still only have the old fields). CI runs make buf and fails if it produces a diff (.github/workflows/check-generate.yml:126-128), so please rerun make buf (or at least regenerate TS/Python/Rust outputs) and commit the updated generated files.

Copilot uses AI. Check for mistakes.
}

// Reponse message for tailing logs.
Expand Down
8 changes: 8 additions & 0 deletions flyteidl2/workflow/run_logs_service.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,14 @@ message TailLogsRequest {

// The attempt number.
uint32 attempt = 2 [(buf.validate.field).uint32.gt = 0];

// +optional. Connector task type name (e.g. "airflow", "batch_job"). When set, the run service forwards this
// hint to the dataplane so log requests for connector tasks can be routed to the connector's GetTaskLogs RPC
// instead of pod logs. The UI populates this from the task template it already loaded for the run.
string task_type = 3;

// +optional. Connector task type version. Used together with task_type to identify a TaskCategory.
int32 task_type_version = 4;
Comment on lines +28 to +34
Copy link

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After adding these fields, the TypeScript/Python/Rust generated bindings in this repo should be regenerated and committed as well (TailLogsRequest in gen/ts + gen/python currently doesn’t include task_type/task_type_version). CI enforces make buf produces a clean diff (.github/workflows/check-generate.yml:126-128), so please run make buf and commit the resulting generated changes.

Copilot uses AI. Check for mistakes.
}

// Reponse message for tailing logs.
Expand Down
160 changes: 92 additions & 68 deletions gen/go/flyteidl2/dataproxy/dataproxy_service.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 4 additions & 0 deletions gen/go/flyteidl2/dataproxy/dataproxy_service.pb.validate.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

101 changes: 63 additions & 38 deletions gen/go/flyteidl2/workflow/run_logs_service.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions gen/go/flyteidl2/workflow/run_logs_service.pb.validate.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 6 additions & 12 deletions gen/go/gateway/flyteidl2/dataproxy/dataproxy_service.swagger.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading