-
Notifications
You must be signed in to change notification settings - Fork 812
feat(connector): record connector endpoint on LogContext #7317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pingsutw
wants to merge
14
commits into
flyteorg:main
Choose a base branch
from
pingsutw:connector-log-context-main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
067e160
feat(connector): record connector endpoint on LogContext
pingsutw b0fc84c
address PR feedback: stash endpoint on ResourceWrapper + regen non-Go…
pingsutw 035d73b
feat(connector): also stash endpoint on Resource returned by Create()
pingsutw 96762d4
make gen
pingsutw eab57cc
feat(dataproxy): add connector_endpoint to TailLogsRequest
pingsutw eb2b5a8
log when LogContext.connector.endpoint is recorded
pingsutw 332ef92
log connector endpoint in getLogContextAndClusterForAttempt
pingsutw 57aeeb2
GetActionLogContext: return cluster even when LogContext is nil
pingsutw 5c4b05b
feat(connector): structured log lines on GetTaskLogsResponseBody
pingsutw 2b2327a
make gen
pingsutw 66badad
make gen
pingsutw cc9d80c
make gen
pingsutw 28fae1c
make gen & add tests
pingsutw 7087429
make-gen
pingsutw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.