Skip to content

Add labels to create run /list runs api. #7430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
afbrock merged 1 commit into from
Jun 9, 2026
Merged

Add labels to create run /list runs api. #7430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions flyteidl2/common/list.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,20 +62,24 @@ message Filter {
VALUE_IN = 7;

// NOT_CONTAINS = 8;
// VALUE_NOT_IN = 9;
VALUE_NOT_IN = 9;
// STARTS_WITH = 10;
// NOT_STARTS_WITH = 11;

ENDS_WITH = 12;
NOT_ENDS_WITH = 13;
CONTAINS_CASE_INSENSITIVE = 14; // Case insensitive contains function.
EXISTS = 15;
NOT_EXISTS = 16;
}

Function function = 1;

// e.g. name or version
string field = 2;

// Only in the case of a VALUE_IN function, values may contain multiple entries.
// Only in the case of a VALUE_IN or VALUE_NOT_IN functions, values may contain multiple entries.
repeated string values = 3;

// Next field number: 17
}
8 changes: 8 additions & 0 deletions flyteidl2/workflow/run_definition.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,14 @@ option go_package = "github.com/flyteorg/flyte/v2/gen/go/flyteidl2/workflow";
message Run {
// Lightweight information about the root action.
Action action = 1;

// User-defined labels attached to this run at creation time. These are the same
// labels as RunSpec.labels (the k8s resource labels applied to pods/jobs at
// execution time, also configurable via settings). On create, labels supplied on
// the request are merged with settings/RunSpec labels, with request labels taking
// precedence, and the merged set is stored here and on the RunSpec.
// It is part of Run so that it gets returned in a list request.
map<string, string> labels = 2;

@EngHabu EngHabu Jun 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need it here? RunDetails message has the RunSpec which has Labels

@afbrock afbrock Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs to be in this one because a list request returns Run not RunDetail.

@EngHabu EngHabu Jun 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah I see... is there a Label type to use here 👇🏽 ?

@machichima machichima Jun 8, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use Label as type here?

flyte/flyteidl2/task/run.proto

Line 72 in c206519

Labels labels = 1;

}

message RunDetails {
Expand Down
69 changes: 41 additions & 28 deletions gen/go/flyteidl2/common/list.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading