fix(flyte-binary): route ClusterService through the gRPC ingress#7484
Merged
Conversation
The dataproxy ClusterService (flyteidl2.cluster.ClusterService) is served by the binary but was missing from the ingress grpcPaths, so the ALB returned 404 for /flyteidl2.cluster.ClusterService/*. This breaks any client that calls SelectCluster — e.g. the SDK's CREATE_UPLOAD_LOCATION path before uploading inputs fails with "SelectCluster failed: Not Found". Add the ClusterService gRPC paths alongside the other flyteidl2 services. Signed-off-by: Kevin Su <pingsutw@apache.org>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Flyte Binary’s gRPC ingress routing by adding missing ingress paths for the flyteidl2.cluster.ClusterService, which is served by the dataproxy but previously returned 404s (e.g., for SelectCluster) when accessed through the ALB gRPC ingress.
Changes:
- Add
/flyteidl2.cluster.ClusterServiceand/flyteidl2.cluster.ClusterService/*to the Helm helper-defined gRPC ingress paths list so requests like/flyteidl2.cluster.ClusterService/SelectClusterare routed correctly.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sovietaced
approved these changes
Jun 9, 2026
machichima
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Why are the changes needed?
The dataproxy
ClusterService(flyteidl2.cluster.ClusterService) is served by thebinary (
dataproxy/setup.gomountsNewClusterServiceHandler), but it was missing fromthe ingress
grpcPaths. As a result the ALB returns HTTP 404 for/flyteidl2.cluster.ClusterService/*.Any client that calls
SelectClusteris broken by this. In particular the SDK callsSelectClusterwithoperation=OPERATION_CREATE_UPLOAD_LOCATIONbefore uploading taskinputs, so it fails with:
What changes were proposed in this pull request?
templates/_helpers.tpl— add/flyteidl2.cluster.ClusterServiceand/flyteidl2.cluster.ClusterService/*toflyte-binary.ingress.grpcPaths, alongside theother
flyteidl2.*services (next toDataProxyService, sinceClusterServicelives inthe dataproxy package). The path points at the same HTTP/gRPC backend as the other
services.
How was this patch tested?
helm template --set ingress.create=true --set ingress.separateGrpcIngress=truenowrenders the two
ClusterServicepaths in the gRPC ingress.helm lint charts/flyte-binarypasses.POST /flyteidl2.cluster.ClusterService/SelectClusterreturned
404; after adding the routes it returns200and the SDK's upload path succeeds.Labels
fixed
Check all the applicable boxes