Skip to content

Apply pod template labels and annotations to Spark applications#7514

Merged
Tom-Newton merged 4 commits into
flyteorg:masterfrom
Tom-Newton:tomnewton/apply_pod_tempalte_labels_and_annotations
Jun 16, 2026
Merged

Apply pod template labels and annotations to Spark applications#7514
Tom-Newton merged 4 commits into
flyteorg:masterfrom
Tom-Newton:tomnewton/apply_pod_tempalte_labels_and_annotations

Conversation

@Tom-Newton

@Tom-Newton Tom-Newton commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Tracking issue

Somewhat tenuously related to #6348

Why are the changes needed?

Currently labels and annotations from pod templates are not propagated to driver and executor pods of spark applications. This affects default pod templates and the pod_template argument to @task. driver_pod and executor_pod arguments already work.

What changes were proposed in this pull request?

  • Merge in the labels and annotations from pod templates.
  • I considered adding these labels and annotations on the top level spark applciation object, so that the spark-opeartor could merge them into pods. I think this is how ray does it, but the spark operator only merges in labels, not annotations.

How was this patch tested?

  • Updated a unit test
  • Deployed it in our cluster and it works.

Check all the applicable boxes

  • I updated the documentation accordingly. - I don't think any update is necessary
  • All new and existing tests passed.
  • All commits are signed-off.

@Tom-Newton Tom-Newton added the changed For changes in existing functionality label Jun 12, 2026
@github-actions github-actions Bot added the flyte label Jun 12, 2026
@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.03%. Comparing base (fb49a7f) to head (d5018b8).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7514   +/-   ##
=======================================
  Coverage   57.03%   57.03%           
=======================================
  Files         931      931           
  Lines       58387    58389    +2     
=======================================
+ Hits        33301    33303    +2     
  Misses      22025    22025           
  Partials     3061     3061           
Flag Coverage Δ
unittests-datacatalog 53.51% <ø> (ø)
unittests-flyteadmin 53.15% <ø> (ø)
unittests-flytecopilot 43.06% <ø> (ø)
unittests-flytectl 64.09% <ø> (ø)
unittests-flyteidl 75.71% <ø> (ø)
unittests-flyteplugins 60.35% <100.00%> (+<0.01%) ⬆️
unittests-flytepropeller 53.79% <ø> (ø)
unittests-flytestdlib 62.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Tom-Newton Tom-Newton marked this pull request as ready for review June 12, 2026 16:10
@Tom-Newton Tom-Newton merged commit 7dc9b56 into flyteorg:master Jun 16, 2026
85 of 89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changed For changes in existing functionality flyte

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants