Add disable identity enrichment flag for ListApps#7536
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a request-level flag to flyteidl2.app.ListRequest to allow callers to opt out of identity enrichment work while keeping the default behavior unchanged (flag defaults to false).
Changes:
- Added
disable_identity_enrichmenttoflyteidl2.app.ListRequest. - Regenerated Go protobuf output for the new field.
- Regenerated Go validation output (no validation rules applied for the new field).
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
flyteidl2/app/app_payload.proto |
Adds the disable_identity_enrichment field to ListRequest. |
gen/go/flyteidl2/app/app_payload.pb.go |
Regenerated Go protobuf bindings including the new field + getter. |
gen/go/flyteidl2/app/app_payload.pb.validate.go |
Regenerated validation code noting no rules for the new field. |
Files not reviewed (2)
- gen/go/flyteidl2/app/app_payload.pb.go: Generated file
- gen/go/flyteidl2/app/app_payload.pb.validate.go: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mhotan
previously approved these changes
Jun 17, 2026
katrogan
previously approved these changes
Jun 17, 2026
katrogan
left a comment
Contributor
There was a problem hiding this comment.
LGTM but I think you need to regen protos in all languages, right?
katrogan
previously approved these changes
Jun 18, 2026
Signed-off-by: pmahindrakar-oss <prafulla.mahindrakar@gmail.com>
59740c4 to
eec83e8
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 7 changed files in this pull request and generated 1 comment.
Files not reviewed (3)
- gen/go/flyteidl2/app/app_payload.pb.go: Generated file
- gen/go/flyteidl2/app/app_payload.pb.validate.go: Generated file
- gen/python/flyteidl2/app/app_payload_pb2.py: Generated file
| common.ProjectIdentifier project = 4; | ||
| } | ||
|
|
||
| // Disable caller identity enrichment in the response. |
katrogan
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Some AppService List callers only need app metadata/spec/status and do not need display-oriented identity enrichment in the response.
This adds an explicit request-level opt-out so those callers can avoid unnecessary identity enrichment work while preserving the existing default behavior for current callers.
What changes were proposed in this pull request?
disable_identity_enrichmenttoflyteidl2.app.ListRequest.The new field defaults to
false, so existing clients continue to receive the current behavior unless they explicitly opt out.How was this patch tested?