Skip to content

Add disable identity enrichment flag for ListApps#7536

Merged
pmahindrakar-oss merged 2 commits into
mainfrom
add-exclude-enrichment-apps
Jun 18, 2026
Merged

Add disable identity enrichment flag for ListApps#7536
pmahindrakar-oss merged 2 commits into
mainfrom
add-exclude-enrichment-apps

Conversation

@pmahindrakar-oss

Copy link
Copy Markdown
Contributor

Why are the changes needed?

Some AppService List callers only need app metadata/spec/status and do not need display-oriented identity enrichment in the response.
This adds an explicit request-level opt-out so those callers can avoid unnecessary identity enrichment work while preserving the existing default behavior for current callers.

What changes were proposed in this pull request?

  • Add disable_identity_enrichment to flyteidl2.app.ListRequest.
  • Regenerate the Go protobuf and validation artifacts.

The new field defaults to false, so existing clients continue to receive the current behavior unless they explicitly opt out.

How was this patch tested?

go test ./gen/go/flyteidl2/app

### Labels

changed

### Setup process

N/A

### Screenshots

N/A

## Check all the applicable boxes

- [ ] I updated the documentation accordingly.
- [x] All new and existing tests passed.
- [ ] All commits are signed-off.

## Related PRs

Union cloud PR will consume this request flag.

## Stack
<!-- branch-stack -->

## Docs link

N/A

Copilot AI review requested due to automatic review settings June 17, 2026 06:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a request-level flag to flyteidl2.app.ListRequest to allow callers to opt out of identity enrichment work while keeping the default behavior unchanged (flag defaults to false).

Changes:

  • Added disable_identity_enrichment to flyteidl2.app.ListRequest.
  • Regenerated Go protobuf output for the new field.
  • Regenerated Go validation output (no validation rules applied for the new field).

Reviewed changes

Copilot reviewed 1 out of 3 changed files in this pull request and generated 1 comment.

File Description
flyteidl2/app/app_payload.proto Adds the disable_identity_enrichment field to ListRequest.
gen/go/flyteidl2/app/app_payload.pb.go Regenerated Go protobuf bindings including the new field + getter.
gen/go/flyteidl2/app/app_payload.pb.validate.go Regenerated validation code noting no rules for the new field.
Files not reviewed (2)
  • gen/go/flyteidl2/app/app_payload.pb.go: Generated file
  • gen/go/flyteidl2/app/app_payload.pb.validate.go: Generated file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread flyteidl2/app/app_payload.proto
mhotan
mhotan previously approved these changes Jun 17, 2026
katrogan
katrogan previously approved these changes Jun 17, 2026

@katrogan katrogan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I think you need to regen protos in all languages, right?

@pmahindrakar-oss pmahindrakar-oss dismissed stale reviews from katrogan and mhotan via 59740c4 June 18, 2026 00:20
@pmahindrakar-oss pmahindrakar-oss enabled auto-merge (squash) June 18, 2026 00:26
katrogan
katrogan previously approved these changes Jun 18, 2026
Signed-off-by: pmahindrakar-oss <prafulla.mahindrakar@gmail.com>
Signed-off-by: pmahindrakar-oss <prafulla.mahindrakar@gmail.com>
Copilot AI review requested due to automatic review settings June 18, 2026 06:16
@pmahindrakar-oss pmahindrakar-oss force-pushed the add-exclude-enrichment-apps branch from 59740c4 to eec83e8 Compare June 18, 2026 06:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 7 changed files in this pull request and generated 1 comment.

Files not reviewed (3)
  • gen/go/flyteidl2/app/app_payload.pb.go: Generated file
  • gen/go/flyteidl2/app/app_payload.pb.validate.go: Generated file
  • gen/python/flyteidl2/app/app_payload_pb2.py: Generated file

common.ProjectIdentifier project = 4;
}

// Disable caller identity enrichment in the response.
@pmahindrakar-oss pmahindrakar-oss merged commit 1b3ec68 into main Jun 18, 2026
23 checks passed
@pmahindrakar-oss pmahindrakar-oss deleted the add-exclude-enrichment-apps branch June 18, 2026 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants