chore(flyte-binary): remove dead config from values.yaml#7559
Merged
Conversation
Two keys in the chart's values.yaml are not referenced by any template: - flyteconnector (top-level): a bare enabled flag left over from the v1 bundled-connector subchart; no template consumes .Values.flyteconnector. - configuration.storage.userDataContainer: the chart only renders metadataContainer (as storage.container); userDataContainer is never read, so setting it has no effect. Remove both and regenerate the README. helm template output is byte-identical before and after, confirming nothing consumed them. Signed-off-by: Kevin Su <pingsutw@apache.org>
The v2 binary has no self-hosted OAuth2 authorization server. It registers no 'auth' config section; runs/config reads only authMetadata.* (external/delegated auth) and advertises a public client via authMetadata.flyteClient. So the chart's '014-auth-secrets.yaml' rendering (auth.appAuth.selfAuthServer. staticClients) was never consumed, and with it gone the entire configuration.auth block in values.yaml (oidc, internal, flyteClient, authorizedUris, clientSecretsExternalSecretRef, enable* gates) is dead. Remove both and replace the values block with a pointer to flyte-core-components.runs.authMetadata. helm template output is unchanged for default values, and the selfAuthServer secret no longer renders even when the old auth.* values are forced on. Signed-off-by: Kevin Su <pingsutw@apache.org>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes Helm chart values and a template fragment in charts/flyte-binary that are not consumed by any template and are not read by the v2 unified binary, to avoid documenting no-op configuration.
Changes:
- Removed unused
configuration.storage.userDataContainerfromvalues.yamland the generated README parameters table. - Removed the unused
configuration.authblock fromvalues.yamland deleted the corresponding auth Secret rendering block fromtemplates/config-secret.yaml. - Removed the unused top-level
flyteconnector.enabledvalue and updatedREADME.mdaccordingly.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| charts/flyte-binary/values.yaml | Deletes dead config keys and replaces the old auth section with a guidance comment. |
| charts/flyte-binary/templates/config-secret.yaml | Removes an unused Secret fragment that rendered selfAuthServer/staticClients auth config. |
| charts/flyte-binary/README.md | Regenerates helm-docs output to drop removed parameters from the table. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sovietaced
previously approved these changes
Jun 18, 2026
Follow-up to the flyte-binary cleanup: the devbox chart still set and documented flyte-binary.configuration.storage.userDataContainer, a no-op value. Remove it so the charts stay consistent. (README edited surgically; the devbox README has other unrelated drift that is out of scope here and not covered by CI helm-docs checks.) Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
AdilFayyaz
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
While auditing the
flyte-binarychart we found several keys invalues.yaml(and onetemplate block) that no template consumes and the v2 binary never reads. They render
nothing, but they show up in the generated README and mislead operators into thinking
they configure something.
What changes were proposed in this pull request?
Remove dead configuration from the chart:
flyteconnector(top-level) — a bareenabledflag left over from v1's bundledconnector subchart. No template references
.Values.flyteconnector.configuration.storage.userDataContainer— the chart only rendersmetadataContainer(asstorage.container);userDataContaineris never read, sosetting it has no effect.
selfAuthServer) — the v2 binary has no self-hosted OAuth2authorization server. It registers no
authconfig section;runs/configreads onlyauthMetadata.*(external/delegated auth) and advertises a public client viaauthMetadata.flyteClient. So the014-auth-secrets.yamlblock inconfig-secret.yaml(
auth.appAuth.selfAuthServer.staticClients) was never consumed. Removing it makes theentire
configuration.authblock dead, so that is removed too and replaced with apointer comment to
flyte-core-components.runs.authMetadata(where v2 auth actuallylives) and the ingress-level SSO.
README.mdis regenerated viahelm-docsto match.No functional change: these values were already ignored, and Helm does not error on
unknown values, so users who set any of them are unaffected.
How was this patch tested?
helm templateoutput is byte-identical before and after for default values.selfAuthServersecret no longer renders even whenconfiguration.auth.enabled,enableAuthServer, andinternal.clientSecretHashare forced on with--set.helm lintpasses.README.mdregenerated withhelm-docs; only the removed keys disappear from theparameter table.
Labels
Check all the applicable boxes