Rename ActionMetadata.funtion_name to function_name#7560
Open
SAY-5 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
Author
|
/regen |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes #7558
Why are the changes needed?
The protobuf field
ActionMetadata.funtion_nameis misspelled (missing thecin "function"). The typo is exposed through the generated stubs in every language and the publishedflyteidl2package that the Python SDK depends on, so the misspelled name leaks into public API surfaces.What changes were proposed in this pull request?
flyteidl2/workflow/run_definition.proto: rename fieldfuntion_nametofunction_name, keeping wire number13so the change is backward-compatible on the wire.runs/service/run_service.go: update the two hand-written references (actionMetadataFromModeland the metadata assignment around line 1832) fromFuntionNametoFunctionName.The
gen/stubs are generated and needmake buf, which I do not have the toolchain for locally. Per the issue's note, I'll comment/regenon this PR so CI regenerates and commits the Go/Python/TypeScript/Rust stubs.How was this patch tested?
gofmt -l runs/service/run_service.goreports no formatting issues, andgrep -rn "funtion" .returns nothing outside the still-to-be-regeneratedgen/stubs. The Go backend will build once the stubs are regenerated via/regen, sinceruns/...is the only hand-written consumer of the renamed proto symbol.Labels
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Stack
If you do use
git townto manage PR Stacks, the stack relevant to this PRwill show below. Otherwise, you can ignore this section.
Docs link