Skip to content

Rename ActionMetadata.funtion_name to function_name#7560

Open
SAY-5 wants to merge 1 commit into
flyteorg:mainfrom
SAY-5:fix/actionmetadata-function-name-typo
Open

Rename ActionMetadata.funtion_name to function_name#7560
SAY-5 wants to merge 1 commit into
flyteorg:mainfrom
SAY-5:fix/actionmetadata-function-name-typo

Conversation

@SAY-5

@SAY-5 SAY-5 commented Jun 19, 2026

Copy link
Copy Markdown

Tracking issue

Closes #7558

Why are the changes needed?

The protobuf field ActionMetadata.funtion_name is misspelled (missing the c in "function"). The typo is exposed through the generated stubs in every language and the published flyteidl2 package that the Python SDK depends on, so the misspelled name leaks into public API surfaces.

What changes were proposed in this pull request?

  • flyteidl2/workflow/run_definition.proto: rename field funtion_name to function_name, keeping wire number 13 so the change is backward-compatible on the wire.
  • runs/service/run_service.go: update the two hand-written references (actionMetadataFromModel and the metadata assignment around line 1832) from FuntionName to FunctionName.

The gen/ stubs are generated and need make buf, which I do not have the toolchain for locally. Per the issue's note, I'll comment /regen on this PR so CI regenerates and commits the Go/Python/TypeScript/Rust stubs.

How was this patch tested?

gofmt -l runs/service/run_service.go reports no formatting issues, and grep -rn "funtion" . returns nothing outside the still-to-be-regenerated gen/ stubs. The Go backend will build once the stubs are regenerated via /regen, since runs/... is the only hand-written consumer of the renamed proto symbol.

Labels

  • changed

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Stack

If you do use git town to manage PR Stacks, the stack relevant to this PR
will show below. Otherwise, you can ignore this section.

Docs link

Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
@github-actions github-actions Bot added the flyte label Jun 19, 2026
@SAY-5 SAY-5 changed the base branch from master to main June 19, 2026 00:05
@SAY-5

SAY-5 commented Jun 19, 2026

Copy link
Copy Markdown
Author

/regen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix typo: rename ActionMetadata.funtion_name → function_name (proto, backend, SDK stubs)

1 participant