fix multipart blob dimensionality for directory uploads#7621
Open
ApfelPresse wants to merge 1 commit into
Open
fix multipart blob dimensionality for directory uploads#7621ApfelPresse wants to merge 1 commit into
ApfelPresse wants to merge 1 commit into
Conversation
Signed-off-by: kev <apfelpresse@mailbox.org> Signed-off-by: kev <12345678+ApfelPresse@users.noreply.github.com>
ApfelPresse
force-pushed
the
fix/multipart-blob-directory-literal
branch
from
23387e6 to
48814b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Directory blob uploads currently return a blob literal with SINGLE dimensionality, even though uploading a directory represents a multipart blob.
What changes were proposed in this pull request?
This PR updates the directory upload path in handleBlobType to return a blob literal with MULTIPART dimensionality.
It also adds a regression test that verifies a directory-based blob upload produces output metadata with:
dimensionality: MULTIPART
How was this patch tested?
Added a unit test for multipart blob uploads.
Tested with:
go test ./flytecopilot/data
Result:
PASS
ok github.com/flyteorg/flyte/flytecopilot/data
In addition, we built a Flyte container image with this patch applied to our current Flyte version and tested it in our environment. The patched version correctly returns multipart blob outputs with MULTIPART dimensionality for directory uploads.
Labels
fixed
Check all the applicable boxes