Skip to content

add short_description to Task and Workflow model - #3224

Merged
cosmicbboy merged 3 commits into
masterfrom
nielsb/add-task-wf-short-description
Sep 3, 2025
Merged

cosmicbboy merged 3 commits into
masterfrom
nielsb/add-task-wf-short-description

Conversation

@cosmicbboy

@cosmicbboy cosmicbboy commented Apr 11, 2025 •

Copy link
Copy Markdown
Contributor

Why are the changes needed?

Currently, short_description is defined in the Task and Workflow protos but are not being piped through in the flytekit Task and Workflow models.

What changes were proposed in this pull request?

  • flytekit.models.tasks.Task now takes a short_description as input
  • flytekit.models.admin.workflow.Workflow now takes a short_description as input

How was this patch tested?

Unit tests were updates

Summary by Bito

This PR adds a new short_description parameter to Task and Workflow classes in flytekit models, including constructor modifications, property methods, and updated serialization for protocol buffer conversion. Tests have been updated to verify these new capabilities.

Unit tests added: True

Estimated effort to review (1-5, lower is better): 2

@flyte-bot

flyte-bot commented Apr 11, 2025 •

Copy link
Copy Markdown
Contributor

Code Review Agent Run #7f0c3a

Actionable Suggestions - 0
Review Details
  • Files reviewed - 3 · Commit Range: 1cb6ad0..1cb6ad0
    • flytekit/models/admin/workflow.py
    • flytekit/models/task.py
    • tests/flytekit/unit/remote/test_remote.py
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

Refer to the documentation for additional commands.

Configuration

This repository uses code_review_bito You can customize the agent settings here or contact your Bito workspace admin at haytham@union.ai.

Documentation & Help

AI Code Review powered by Bito Logo

Comment thread flytekit/models/admin/workflow.py Outdated
@flyte-bot

Copy link
Copy Markdown
Contributor

Changelist by Bito

This pull request implements the following key changes.

Key Change Files Impacted
New Feature - Model Enhancement: Add short_description

- workflow.py - Constructor updated to include short_description, property added for accessing it, and workflow serialization updated to pass the new field.

- task.py - Constructor updated to include short_description, property added for accessing it, and task serialization updated to incorporate the new field.

Testing - Test Update: Incorporate short_description

- test_remote.py - Test cases adjusted to supply short_description for both Task and Workflow objects, ensuring the new parameter is correctly handled.

wild-endeavor
wild-endeavor previously approved these changes Apr 11, 2025
@codecov

codecov Bot commented Apr 11, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 52.16%. Comparing base (33197e7) to head (1cb6ad0).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
flytekit/models/admin/workflow.py 66.66% 2 Missing ⚠️
flytekit/models/task.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3224   +/-   ##
=======================================
  Coverage   52.15%   52.16%           
=======================================
  Files         214      214           
  Lines       22299    22307    +8     
  Branches     2924     2924           
=======================================
+ Hits        11630    11636    +6     
- Misses       9986     9988    +2     
  Partials      683      683           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cosmicbboy
cosmicbboy enabled auto-merge (squash) September 2, 2025 19:16
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
@cosmicbboy
cosmicbboy force-pushed the nielsb/add-task-wf-short-description branch from 1cb6ad0 to 8ef6126 Compare September 2, 2025 19:18
@flyte-bot

Copy link
Copy Markdown
Contributor

Bito Automatic Review Failed - Technical Failure

Bito encountered technical difficulties while generating code feedback . To retry, type /review in a comment and save. If the issue persists, contact support@bito.ai and provide the following details:

Agent Run ID: ab171752-b223-47d6-baef-5eb1a89cdc62

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
@flyte-bot

Copy link
Copy Markdown
Contributor

Bito Automatic Review Failed - Technical Failure

Bito encountered technical difficulties while generating code feedback . To retry, type /review in a comment and save. If the issue persists, contact support@bito.ai and provide the following details:

Agent Run ID: 59825afa-b742-4bf8-94de-a378afb2d889

@cosmicbboy
cosmicbboy merged commit 44af03f into master Sep 3, 2025
53 of 60 checks passed
@cosmicbboy
cosmicbboy deleted the nielsb/add-task-wf-short-description branch September 3, 2025 13:59
Atharva1723 pushed a commit to Atharva1723/flytekit that referenced this pull request Oct 5, 2025
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Atharva <atharvakulkarni172003@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants