Repository navigation
fix: keep flytekit on s3fs/gcsfs/adlfs when another library registers a different fsspec implementation - #3472
Merged
Merged
Conversation
AdilFayyaz
requested review from
cosmicbboy,
davidmirror-ops,
kumare3,
machichima,
pingsutw,
samhita-alla and
wild-endeavor
as code owners
October 2, 2026 17:23
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3472 +/- ##
==========================================
- Coverage 86.67% 83.58% -3.09%
==========================================
Files 443 3 -440
Lines 37040 195 -36845
Branches 3036 0 -3036
==========================================
- Hits 32106 163 -31943
+ Misses 4052 32 -4020
+ Partials 882 0 -882 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
kumare3
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Importing a library that registers its own fsspec implementation for s3/gs/abfs with clobber=True (e.g. the Flyte 2 SDK, flyte, which registers obstore) silently replaces the filesystem flytekit uses. obstore ignores the call kwargs flytekit relies on. On GCS, this means deck.html is stored without content_type="text/html", so the console downloads the deck instead of rendering it. On S3, the upload fails outright, because obstore rejects s3fs constructor kwargs such as cache_regions.
What changes were proposed in this pull request?
registered implementation is used only if it subclasses that default (as flytekitplugins-async-fsspec's AsyncS3FileSystem does).
chunksize handling for every flytekit upload and download, not just decks.
How was this patch tested?
change.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link