Conversation
…nd fix a small docstring typo
… of yt, remove unnecessary imports and function
scripts/magnetopause3d.py
Outdated
|
|
||
| #Create streamline seeds (starting points for streamlines) | ||
| seedN = 50 #seeds per row, final seed count will be seedN*seedN ! | ||
| seedN = 25 #seeds per row, final seed count will be seedN*seedN ! |
There was a problem hiding this comment.
This should be a (default) parameter for the function
There was a problem hiding this comment.
e.g. def make_streamlines(vlsvFileName, seedN=25):
scripts/magnetopause3d.py
Outdated
| @@ -185,27 +148,27 @@ def make_streamlines(vlsvFileName): | |||
| streamline_seeds[k] = [20, i, j] | |||
alhom
left a comment
alhom
left a comment
There was a problem hiding this comment.
As these are aimed to be included in the analysator modules, I'd like a top-level callable function like find_magnetopause(vlsvfile, seedN=25, x0=20 Re, ...) (with inputs in SI) that wraps the existing parts of main()s (~below) that actually gather the magnetopause, and return the triangle mesh. Ditto for magnetopause2d (incl. default parameter comments).
def main():
## STREAMLINES
streams = make_streamlines(fileLocation+fileN)
## MAGNETOPAUSE
magnetopause = make_magnetopause(streams)
… takes a vlsvfile name and keyword arguments and returns magnetopause as triangle mesh vertices and faces (3d) or array (2d). Remove unnecessary functions, change units from RE to m.
…or streamline seeds.
…ing function from calculations
…y) fix import issues
Documentation/sphinx/scripts.rst
Outdated
| magnetopause2d | ||
| -------------- | ||
| :doc:`magnetopause2d` | ||
| magnetopause_sw_streamline_2d |
There was a problem hiding this comment.
These are now documented by autodoc in pyCalculations, rather have the example scripts described here (or rather, similarly under a new examples page!)
|
|
||
| ------------ | ||
|
|
||
| magnetopause2d |
There was a problem hiding this comment.
Restore these to point towards your plot scripts
|
Included in #338. |
2 participants
Updates and documentation for magnetopause finding with streamlines.