Swapped cut_through for lineout in cutthrough_timeseries#438
Merged
alhom merged 13 commits intofmihpc:masterfrom Mar 9, 2026
Merged
Swapped cut_through for lineout in cutthrough_timeseries#438alhom merged 13 commits intofmihpc:masterfrom
alhom merged 13 commits intofmihpc:masterfrom
Conversation
Contributor
Author
|
Testing is troublesome, there appears to be a memory leak somewhere |
Contributor
Author
It works, but the new npoints parameter should be chosen reasonably. 100 results in memory leak in this case, for instance 
|
Contributor
Author
|
The memory leak: In an interactive job with 32GB memory, the python process is killed after approx 27 timesteps have been processed with npoints=100. In a job with 64GB memory, it is killed after approx 50 timesteps |
Contributor
Author
|
Do we wait for the CI to finish before merging? |
Member
|
Let me fix the cut-through into this PR and we can have the 0-order work through that, sanely. Also adding some sanity checks for the number of lineout points to warn about undersampling. |
…used variables to dummy. Add helper function to find smallest SpatialGrid dx/cell lengths.
… instead of saving an image
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fixed some old incompatible code in other files
Testing pending