Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if a default value is provided, don't expand the dropdown on page load #176

Closed
wants to merge 1 commit into from

Conversation

zdhickman
Copy link
Contributor

Following up on #151, this is an implementing patch if you'd like it!

@@ -29,7 +29,7 @@
],
"repository": {
"type": "git",
"url": "https://github.com/fmoo/react-typeahead.git"
"url": "https://github.com/HubSpot/react-typeahead.git"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, the last two commits in this PR should not be here. I'll clean that up.

@fmoo
Copy link
Owner

fmoo commented Apr 2, 2016

Please leave the lib/ out of the PR; lib is compiled as part of prepublish automatically.

@nosilleg - Was thinking of getting this into the 1.1.x release; any concerns if I do?

@nosilleg
Copy link
Contributor

nosilleg commented Apr 2, 2016

What is the usage scenario for this change? This seems like it would impact a lot of different use cases. Is there an issue (ticket) for this? If not, can an issue be created so that we can discuss the validity of the functionality change? (as opposed to addressing the code in here)

@fmoo Thanks for including me on this. I've got other changes that are part completed for the next rev of the component (obvs pending your approval) one of which is the potential removal of defaultValue if/when I confirm that it's redundant in the controlled component version.

@fmoo
Copy link
Owner

fmoo commented Apr 2, 2016

@nosilleg - I think the main issue is #151 (also #21?), but there are 2-3 other reports/questions around typeahead on textentry.blur / non-focus that could be related (#169, #154, #129, #115, #113, and maybe #104)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants