Skip to content

fix: add missing expand to update reducer on badge scan edit - #1048

Open
tomrndom wants to merge 1 commit into
masterfrom
fix/edit-badge-scan-refresh
Open

fix: add missing expand to update reducer on badge scan edit#1048
tomrndom wants to merge 1 commit into
masterfrom
fix/edit-badge-scan-refresh

Conversation

@tomrndom

@tomrndom tomrndom commented Aug 21, 2026

Copy link
Copy Markdown

ref: https://app.clickup.com/t/9014802374/86bbj3r74

Signed-off-by: Tomás Castillo tcastilloboireau@gmail.com

Summary by CodeRabbit

  • Bug Fixes
    • Badge scan updates now retain and return associated extra questions when applicable.

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 216527bd-c659-4e91-978f-d74833371646

📥 Commits

Reviewing files that changed from the base of the PR and between 5fdfd43 and 785eeda.

📒 Files selected for processing (1)
  • src/actions/sponsor-actions.js

Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


📝 Walkthrough

Walkthrough

The badge scan update request now asks the API to expand extra_questions while retaining the access token.

Changes

Badge scan update

Layer / File(s) Summary
Request expansion parameters
src/actions/sponsor-actions.js
The badge scan update request now includes expand: "extra_questions" alongside the access token.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 785ee

This is a small localized update to refresh badge-scan edits, and no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: smarcet

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the missing expand behavior added to the badge scan update reducer.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/edit-badge-scan-refresh

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant