Clear widget state on unmount instead of on the completion CTA click - #158
Open
gcutrini wants to merge 1 commit into
Open
Clear widget state on unmount instead of on the completion CTA click#158gcutrini wants to merge 1 commit into
gcutrini wants to merge 1 commit into
Conversation
The purchase-complete CTAs cleared the widget's state on click, before navigating. Navigation is async, so the widget stayed mounted and repainted to its initial state during the transition. Move the reset to an unmount effect so the completion screen stays visible until the destination renders. The CTAButton no longer clears; the dead `clear` prop is dropped.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: https://app.clickup.com/t/86bbm1pzz
Problem
On the purchase-complete screen, the CTAs (Finish Now / View My Orders/Tickets /
Access Event) cleared the widget's Redux state on click, before navigating.
Navigation is asynchronous, so the widget stayed mounted and repainted to its
initial state during the transition — a visible flash before the destination
renders.
Fix
Move the reset to an unmount effect (
useEffect(() => () => clearWidgetState(), []))so the completion screen stays visible until the destination renders. The
CTAButton no longer clears on click; its now-dead
clearprop is dropped.Modal reuse still resets: closing the modal unmounts the widget, which fires the
unmount clear.
Tests