style(lsp): make the base LSP label more like others #624
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The base entry had an label with the LSP client name in
parentheses, which pushes the range to the right, making
it more likely that the range will leave the edge of the viewport.
Since the range is more useful information than the LSP client,
change the base label format to be more like the others.
This also improves the appearance of the tree.
e.g.
```
└╴1 ACCOUNT-ENTRY-VIEW VIEW OF DLP-ACCOUNT-ENTRY (natls) [105, 3]
becomes highlighted v---v
└╴1 ACCOUNT-ENTRY-VIEW VIEW OF DLP-ACCOUNT-ENTRY [105, 3] natls
```
awilkins
changed the title
awilkins
changed the title
awilkins
changed the title
|
This PR is stale because it has been open 30 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The base entry has an label with the LSP client name in
parentheses, which pushes the range to the right, making
it more likely that the range will leave the edge of the viewport.
Since the range is more useful information than the LSP client,
change the base label format to be more like the others.
This also improves the appearance of the tree.
e.g.