Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SKIP instead of ERROR if opentype/slant_direction's reference codepoint is not covered #4969

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

Hoolean
Copy link
Contributor

@Hoolean Hoolean commented Jan 13, 2025

Description

opentype/slant_direction errors if a font does not cover H, as it uses its outlines to determine slant direction. There are legitimate reasons for a font to not contain an H however, and so this PR makes this case an explicit SKIP instead.

Checklist

  • update CHANGELOG.md
  • wait for the tests to pass
  • request a review

@felipesanches felipesanches merged commit 7b75e1f into fonttools:main Jan 13, 2025
37 checks passed
@felipesanches
Copy link
Collaborator

thanks, @Hoolean

@Hoolean Hoolean deleted the missing-slnt-reference branch January 13, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants