Fix transport cost related issues #1082
Open
+18
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twothreenine
force-pushed
the
fix/include-transport-costs
branch
from
4205ae6 to
d843be7
Compare
- Include transport costs when calculating the group sum of an order - When creating a foodcoop transaction, use the exact inverted sum of the group transactions to prevent rounding issues - Display transport costs above "The following were not ordered" to avoid confusion
twothreenine
force-pushed
the
fix/include-transport-costs
branch
from
d843be7 to
5f03182
Compare
|
Is this the PR which (also) solves all failing tests on recent PR's? |
No, that has been fixed by c7fc475. This is just the PR where I noticed it. I subsequently reported it and rebased this PR after it was fixed. |
|
Ah... thanks! Never mind... it helps when you pull from the correct repo. I thought I was on the latest master but I was not in the correct local repo which wasn't updated/synced... 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: When creating a foodcoop transaction + finance link when settling an order, the group sum without transport costs was used for the foodcoop transaction, so whenever transport costs were involved, unbalanced finance links were created.
This commit changes:
This value is displayed (among other places) in the balancing summary box. I chose not to include transport costs in
groups_without_markupthough, since that would be more complicated and also because transport costs are some kind of "extra costs."The following were not orderedto avoid confusion.Resolved by c7fc475: checks fail
The checks fail with the following note -- I didn't run them locally, so I don't know whether they'll pass.