W-17980476: exclude folder when folder content is excluded from org connection #1535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillieRuemmele
approved these changes
Apr 7, 2025
| @@ -623,6 +623,63 @@ describe('ComponentSetBuilder', () => { | |||
| expect(compSet.has(apexClassWildcardMatch)).to.equal(true); | |||
| }); | |||
|
|
|||
| it('should exclude folder type when excluding a type that is stored in folders', async () => { | |||
There was a problem hiding this comment.
can we add a test that excludes DasbhoardFolder and makes sure Dashboard is still included?
There was a problem hiding this comment.
This fix doesn't allow that functionality: due to how the listMetadata API works for components in folders (where it needs the folder to get the component), if the folder is excluded then it can't list the components in it.
QA Notes✅ : running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates CSB build() method for when an Org and excluded types are passed in. It will check if the excluded type is a folder content and if so, it will also exclude the folder from the resulting CS.
E.g. if Report type is excluded, it will also exclude ReportFolder.
#3232, @W-17980476@ >